Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operate on packages/modules instead of directories. #526

Closed
LandonTClipp opened this issue Dec 20, 2022 · 1 comment · Fixed by #548
Closed

Operate on packages/modules instead of directories. #526

LandonTClipp opened this issue Dec 20, 2022 · 1 comment · Fixed by #548
Labels

Comments

@LandonTClipp
Copy link
Collaborator

#243 (comment)

@mattdowdell
Copy link

+1 for this feature. My team recently stumbled onto the limitations of operating on directories when working on a module with another modules in a subdirectory, e.g. /path/to/module1 and /path/to/module1/module2. We generated mocks such that they end up in /path/to/module1/mocks/` which ended up causing a circulr dependency because:

  • Module2 import Module1.
  • Module1's mocks are part of the Module1 module.
  • Module1's mocks import Module2.

Our workaround was to generate the Module1 mocks and then delete those that were for Module2 before any other tooling could choke on them, e.g. testing, linting, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants