From f2d9d5999cadc59f767d4571177082e7fd990ade Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20Orb=C3=A1n?= Date: Tue, 17 Oct 2023 16:42:49 +0200 Subject: [PATCH 1/5] chore: lower Node.js version requirement --- packages/create-next-app/package.json | 2 +- packages/next/package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/create-next-app/package.json b/packages/create-next-app/package.json index 81670430a36e0..1dee3b0d569cd 100644 --- a/packages/create-next-app/package.json +++ b/packages/create-next-app/package.json @@ -52,6 +52,6 @@ "validate-npm-package-name": "3.0.0" }, "engines": { - "node": ">=18.18.2" + "node": ">=18.7.1" } } diff --git a/packages/next/package.json b/packages/next/package.json index 81bbba23a2f9e..e1c3b45985c7d 100644 --- a/packages/next/package.json +++ b/packages/next/package.json @@ -316,6 +316,6 @@ "zod": "3.22.3" }, "engines": { - "node": ">=18.18.2" + "node": ">=18.7.1" } } From 8dd60aa391c41b3b3c1b3ef00a352a7d0e7525fd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20Orb=C3=A1n?= Date: Tue, 17 Oct 2023 16:56:59 +0200 Subject: [PATCH 2/5] Update package.json --- packages/create-next-app/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/create-next-app/package.json b/packages/create-next-app/package.json index 1dee3b0d569cd..fea6f7008dfd0 100644 --- a/packages/create-next-app/package.json +++ b/packages/create-next-app/package.json @@ -52,6 +52,6 @@ "validate-npm-package-name": "3.0.0" }, "engines": { - "node": ">=18.7.1" + "node": ">=18.17.1" } } From 0576a21a107b460f36df6cd4c5bcc0fb5db30f6a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20Orb=C3=A1n?= Date: Tue, 17 Oct 2023 16:57:06 +0200 Subject: [PATCH 3/5] Apply suggestions from code review Co-authored-by: Steven --- packages/next/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/next/package.json b/packages/next/package.json index e1c3b45985c7d..20f6baf86d29d 100644 --- a/packages/next/package.json +++ b/packages/next/package.json @@ -316,6 +316,6 @@ "zod": "3.22.3" }, "engines": { - "node": ">=18.7.1" + "node": ">=18.17.0" } } From e9f617f5a00a5f284792b41592f73ef695432c8f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20Orb=C3=A1n?= Date: Tue, 17 Oct 2023 16:57:32 +0200 Subject: [PATCH 4/5] Update package.json --- packages/create-next-app/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/create-next-app/package.json b/packages/create-next-app/package.json index fea6f7008dfd0..e5c08e632b6c2 100644 --- a/packages/create-next-app/package.json +++ b/packages/create-next-app/package.json @@ -52,6 +52,6 @@ "validate-npm-package-name": "3.0.0" }, "engines": { - "node": ">=18.17.1" + "node": ">=18.17.0" } } From b44fd998dfe9e4ae46b8c7f79be213669b161341 Mon Sep 17 00:00:00 2001 From: Steven Date: Tue, 17 Oct 2023 11:15:43 -0400 Subject: [PATCH 5/5] test with 18.17.0 --- .github/actions/next-stats-action/Dockerfile | 2 +- .github/actions/next-stats-action/package.json | 2 +- .github/workflows/build_and_test.yml | 4 ++-- azure-pipelines.yml | 2 +- package.json | 2 +- test/.stats-app/package.json | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/actions/next-stats-action/Dockerfile b/.github/actions/next-stats-action/Dockerfile index bf40f16aecf3e..acdb4b43b92ff 100644 --- a/.github/actions/next-stats-action/Dockerfile +++ b/.github/actions/next-stats-action/Dockerfile @@ -9,7 +9,7 @@ RUN apt install unzip wget curl nano htop screen build-essential pkg-config libs RUN ln $(which python3) /usr/bin/python -RUN curl -sfLS https://install-node.vercel.app/v18.18.2 | bash -s -- -f +RUN curl -sfLS https://install-node.vercel.app/v18.17.0 | bash -s -- -f RUN corepack enable WORKDIR /next-stats diff --git a/.github/actions/next-stats-action/package.json b/.github/actions/next-stats-action/package.json index e70b389294359..71dafeb94e48f 100644 --- a/.github/actions/next-stats-action/package.json +++ b/.github/actions/next-stats-action/package.json @@ -18,7 +18,7 @@ "typescript": "5.1.6" }, "engines": { - "node": ">=18.18.2", + "node": ">=18.17.0", "pnpm": "8.9.0" }, "packageManager": "pnpm@8.9.0" diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index cbe0673cac917..37b1639ceedf7 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -146,7 +146,7 @@ jobs: group: [1, 2, 3, 4, 5] uses: ./.github/workflows/build_reusable.yml with: - nodeVersion: 18.18.2 + nodeVersion: 18.17.0 skipForDocsOnly: 'yes' afterBuild: RUST_BACKTRACE=0 NEXT_EXTERNAL_TESTS_FILTERS="$(pwd)/test/turbopack-tests-manifest.json" TURBOPACK=1 node run-tests.js --timings -g ${{ matrix.group }}/5 -c ${TEST_CONCURRENCY} --type integration secrets: inherit @@ -211,7 +211,7 @@ jobs: uses: ./.github/workflows/build_reusable.yml with: - nodeVersion: 18.18.2 + nodeVersion: 18.17.0 skipForDocsOnly: 'yes' afterBuild: node run-tests.js --timings -g ${{ matrix.group }}/12 -c ${TEST_CONCURRENCY} --type integration secrets: inherit diff --git a/azure-pipelines.yml b/azure-pipelines.yml index 1b5a1d5f9624e..a4a63e68955c0 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -34,7 +34,7 @@ pr: variables: PNPM_CACHE_FOLDER: $(Pipeline.Workspace)/.pnpm-store NEXT_TELEMETRY_DISABLED: '1' - node_version: ^18.18.2 + node_version: ^18.17.0 stages: - stage: Test diff --git a/package.json b/package.json index da15a866dd002..e42ec813c890e 100644 --- a/package.json +++ b/package.json @@ -249,7 +249,7 @@ "@types/react-dom": "18.2.13" }, "engines": { - "node": ">=18.18.2", + "node": ">=18.17.0", "pnpm": "8.9.0" }, "packageManager": "pnpm@8.9.0" diff --git a/test/.stats-app/package.json b/test/.stats-app/package.json index ba87edd44c8f1..f1ad0be262e36 100644 --- a/test/.stats-app/package.json +++ b/test/.stats-app/package.json @@ -8,7 +8,7 @@ "react-dom": "latest" }, "engines": { - "node": ">=18.18.2", + "node": ">=18.17.0", "pnpm": "8.9.0" }, "packageManager": "pnpm@8.9.0"