-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resizing Container Resources Without Restarting Containers #803
Comments
Great, what's the status on migrating the changes from the hy branch into main? |
you can focus on the |
Sounds good, thank you! |
@Lightxyz We already updated invitro and vhive to use k8s 1.29. If that is not enough, please reopen. |
Is your feature request related to a problem? Please describe.
Cannot change CPU requests / limits for pods / containers which are running, without restarting them.
Describe the solution you'd like
An upgrade to Kubernetes version 1.27 would allow us to resize CPU and memory resources assigned to containers without needing to restart them. See the following:
https://kubernetes.io/docs/tasks/configure-pod-container/resize-container-resources/
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.27.md#changelog-since-v1260
"PodSpec.Container.Resources became mutable for CPU and memory resource types."
Describe alternatives you've considered
Editing the cpu.shares and the cpu.cfs_quota_us files enables us to adjust the CPU request and the CPU limit while the container is running, but this may interfere with the Kubernetes scheduler.
EDIT:
The kn service update command can adjust CPU requests / limit and memory requests of pods, but it's unclear whether it will adjust the CPU share that existing pods which are currently processing invocations get.
The text was updated successfully, but these errors were encountered: