New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate profiler in perf_bench_test.go #149

Merged

ustiugov merged 166 commits into vhive-serverless:master from NiuJ1ao:perf_bench_test

Mar 4, 2021

Contributor

NiuJ1ao commented Feb 24, 2021

add toplev from pmu-tools in profiler
add plotter to draw line charts for PMU events
add a short manual

Signed-off-by: NiuJ1ao 26167136+NiuJ1ao@users.noreply.github.com

NiuJ1ao requested a review from ustiugov

February 24, 2021 12:38

NiuJ1ao self-assigned this

ustiugov requested changes

View reviewed changes

Member

ustiugov left a comment

All comments in front of the functions need to start with "functionName does/serves/returns/..."

Other minor changes requested in the comments

docs/profiling.md Show resolved Hide resolved

docs/profiling.md Outdated Show resolved Hide resolved

docs/profiling.md Outdated Show resolved Hide resolved

docs/profiling.md Outdated Show resolved Hide resolved

docs/profiling.md Show resolved Hide resolved

perf_bench_test.go Outdated Show resolved Hide resolved

perf_bench_test.go Outdated Show resolved Hide resolved

perf_bench_test.go Show resolved Hide resolved

perf_bench_test.go Outdated Show resolved Hide resolved

perf_bench_test.go Outdated Show resolved Hide resolved

NiuJ1ao force-pushed the perf_bench_test branch 2 times, most recently from f177393 to 4296d3e Compare

February 26, 2021 17:54

NiuJ1ao requested a review from ustiugov

February 26, 2021 17:55

ustiugov requested changes

View reviewed changes

Member

ustiugov left a comment

Add an intro to the manual that explains what this tool's purpose is. Please pay attention to articles, please proof-read the text there again. Make sure that yu assume no background knowledge of the tool from a user.
bindSocket should take runtime arguments from the user to make sure that core-to-socket affinity is correct on any machine. btw, 2-socket machine is ok but 16+ cores constraint is not reasonable. can be decreased to 10, for example.

Makefile Outdated Show resolved Hide resolved

docs/profiling.md Show resolved Hide resolved

docs/profiling.md Outdated Show resolved Hide resolved

docs/profiling.md Outdated Show resolved Hide resolved

docs/profiling.md Outdated Show resolved Hide resolved

profile/plotter.go Outdated Show resolved Hide resolved

profile/profiler.go Outdated Show resolved Hide resolved

docs/profiling.md Outdated Show resolved Hide resolved

docs/profiling.md Outdated Show resolved Hide resolved

docs/profiling.md Outdated Show resolved Hide resolved

ustiugov added this to the TopDown profiler tool milestone

ustiugov added the enhancement label

ustiugov reviewed

View reviewed changes

Makefile Show resolved Hide resolved

NiuJ1ao force-pushed the perf_bench_test branch from f8e977c to 9a96478 Compare

March 2, 2021 08:13

NiuJ1ao requested a review from ustiugov

March 2, 2021 12:54

NiuJ1ao force-pushed the perf_bench_test branch 9 times, most recently from 7731595 to 6f1e936 Compare

March 2, 2021 14:20

ustiugov requested changes

View reviewed changes

Member

ustiugov left a comment

Need to fix the tests. Need to have the correct module versions in go.mod.

go.mod Outdated Show resolved Hide resolved

perf_bench_test.go Outdated Show resolved Hide resolved

perf_bench_test.go Outdated Show resolved Hide resolved

perf_bench_test.go Show resolved Hide resolved

perf_bench_test.go Outdated Show resolved Hide resolved

perf_bench_test.go Outdated Show resolved Hide resolved

perf_bench_test.go Outdated Show resolved Hide resolved

docs/profiling.md Outdated Show resolved Hide resolved

NiuJ1ao force-pushed the perf_bench_test branch from 6f1e936 to 4faff08 Compare

March 2, 2021 14:32

shyamjesal reviewed

View reviewed changes

docs/profiling.md Outdated Show resolved Hide resolved

shyamjesal reviewed

View reviewed changes

docs/profiling.md Outdated Show resolved Hide resolved

shyamjesal reviewed

View reviewed changes

docs/profiling.md Outdated Show resolved Hide resolved

shyamjesal reviewed

View reviewed changes

docs/profiling.md Show resolved Hide resolved

shyamjesal reviewed

View reviewed changes

docs/profiling.md Show resolved Hide resolved

shyamjesal reviewed

View reviewed changes

docs/profiling.md Outdated Show resolved Hide resolved

NiuJ1ao and others added 23 commits

March 5, 2021 04:10


          add profile to SUBDIRS and remove redundant starts and cleans

50ee8ec

Signed-off-by: NiuJ1ao <26167136+NiuJ1ao@users.noreply.github.com>


          make bind CPU configurable and add logical core ID to physical core I…

f63e859

…D map

Signed-off-by: NiuJ1ao <26167136+NiuJ1ao@users.noreply.github.com>


          proofread and rephrase profiling.md

ad24a31

Signed-off-by: NiuJ1ao <26167136+NiuJ1ao@users.noreply.github.com>


          remove constraints on the number of socket and cores, let both be con…

cb50aa4

…figurable

Signed-off-by: NiuJ1ao <26167136+NiuJ1ao@users.noreply.github.com>


          rename and add install pmutools script to git action

s

Signed-off-by: NiuJ1ao <26167136+NiuJ1ao@users.noreply.github.com>


          add two exceptions to wordlist

484d333

Signed-off-by: NiuJ1ao <26167136+NiuJ1ao@users.noreply.github.com>


          minor fix bugs in profiling core deletion and pmutools installation

e31d645

minor fix bug on deleting profiling physical core

Signed-off-by: NiuJ1ao <26167136+NiuJ1ao@users.noreply.github.com>

minor fix install pmutools in Github action

Signed-off-by: NiuJ1ao <26167136+NiuJ1ao@users.noreply.github.com>


          remove install_pmutools.sh from tests

0795b46

Signed-off-by: NiuJ1ao <26167136+NiuJ1ao@users.noreply.github.com>


          elaborate comments and descriptions

03a65b0

Signed-off-by: NiuJ1ao <26167136+NiuJ1ao@users.noreply.github.com>


          add install pmutools to github runner host set up

1e755f3

Signed-off-by: NiuJ1ao <26167136+NiuJ1ao@users.noreply.github.com>


          minor fix version issues in go.mod and rebase to master

09e2cbd

Signed-off-by: NiuJ1ao <26167136+NiuJ1ao@users.noreply.github.com>


          add install pmu tools to unit test

0fa76b7

Signed-off-by: NiuJ1ao <26167136+NiuJ1ao@users.noreply.github.com>


          minor fix step size

24a46c9

Signed-off-by: NiuJ1ao <26167136+NiuJ1ao@users.noreply.github.com>


          fix data race problem and add comments to bind variables

892c881

Signed-off-by: NiuJ1ao <26167136+NiuJ1ao@users.noreply.github.com>


          rephrase the first two sections

f333013

Signed-off-by: NiuJ1ao <26167136+NiuJ1ao@users.noreply.github.com>


          Apply suggestions from code review

ec2d27f

Manual corrections.

Signed-off-by: Dmitrii Ustiugov <dmitrii.ustiugov@ed.ac.uk>


          Correction of the manual

4f213f1

Signed-off-by: Dmitrii Ustiugov <dmitrii.ustiugov@ed.ac.uk>


          add automated tail-latency-aware profiler

1f9a795

Signed-off-by: NiuJ1ao <26167136+NiuJ1ao@users.noreply.github.com>


          rephrase bind function

dbdc855

Signed-off-by: NiuJ1ao <26167136+NiuJ1ao@users.noreply.github.com>


          fix infinite loop bug and add test argument for runner

8b24b00

Signed-off-by: NiuJ1ao <26167136+NiuJ1ao@users.noreply.github.com>


          move tests from bench to test

e410f70

Signed-off-by: NiuJ1ao <26167136+NiuJ1ao@users.noreply.github.com>


          fix data type casting problem and returned format difference

33b4ecd

Signed-off-by: NiuJ1ao <26167136+NiuJ1ao@users.noreply.github.com>


          correct typo and redundant return

a5addf2

Signed-off-by: NiuJ1ao <26167136+NiuJ1ao@users.noreply.github.com>

correct description of profiler nodes argument

Signed-off-by: NiuJ1ao <26167136+NiuJ1ao@users.noreply.github.com>

NiuJ1ao force-pushed the perf_bench_test branch from f7822c5 to a5addf2 Compare

March 4, 2021 20:11

ustiugov requested changes

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

docs/profiling.md Outdated Show resolved Hide resolved


          correct grammar issues

8b5a13b

Signed-off-by: NiuJ1ao <26167136+NiuJ1ao@users.noreply.github.com>

ustiugov approved these changes

View reviewed changes

ustiugov merged commit 77a3636 into vhive-serverless:master

HermioneKT pushed a commit that referenced this pull request


          # This is a combination of 154 commits.

# This is the 1st commit message:

refactor

# This is the commit message #2:

modify powerNodeSelector

# This is the commit message #3:

modify powerNodeSelector

# This is the commit message #4:

modify powerNodeSelector

# This is the commit message #5:

modify namespace

# This is the commit message #6:

modify namespace

# This is the commit message #7:

add namespace

# This is the commit message #8:

init power manager script

# This is the commit message #9:

add go code

# This is the commit message #10:

test

# This is the commit message #11:

test

# This is the commit message #12:

test

# This is the commit message #13:

test

# This is the commit message #14:

go.sum

# This is the commit message #15:

go sum

# This is the commit message #16:

go mod tidy

# This is the commit message #17:

test

# This is the commit message #18:

test

# This is the commit message #19:

test

# This is the commit message #20:

test

# This is the commit message #21:

test

# This is the commit message #22:

test

# This is the commit message #23:

test

# This is the commit message #24:

test

# This is the commit message #25:

test

# This is the commit message #26:

test

# This is the commit message #27:

test

# This is the commit message #28:

test

# This is the commit message #29:

print output

# This is the commit message #30:

test

# This is the commit message #31:

test

# This is the commit message #32:

test

# This is the commit message #33:

test

# This is the commit message #34:

test

# This is the commit message #35:

test

# This is the commit message #36:

test

# This is the commit message #37:

test

# This is the commit message #38:

test

# This is the commit message #39:

test

# This is the commit message #40:

refactor

# This is the commit message #41:

change val

# This is the commit message #42:

test

# This is the commit message #43:

test

# This is the commit message #44:

test

# This is the commit message #45:

exp1

# This is the commit message #46:

add url

# This is the commit message #47:

test

# This is the commit message #48:

test

# This is the commit message #49:

test auth

# This is the commit message #50:

test

# This is the commit message #51:

test

# This is the commit message #52:

test

# This is the commit message #53:

test

# This is the commit message #54:

test

# This is the commit message #55:

fix bug

# This is the commit message #56:

remove log

# This is the commit message #57:

test

# This is the commit message #58:

test

# This is the commit message #59:

test

# This is the commit message #60:

fix loop

# This is the commit message #61:

increase invocation

# This is the commit message #62:

test

# This is the commit message #63:

test

# This is the commit message #64:

test

# This is the commit message #65:

test

# This is the commit message #66:

test

# This is the commit message #67:

test

# This is the commit message #68:

test

# This is the commit message #69:

Test

# This is the commit message #70:

test

# This is the commit message #71:

test

# This is the commit message #72:

test

# This is the commit message #73:

test

# This is the commit message #74:

test

# This is the commit message #75:

test

# This is the commit message #76:

test

# This is the commit message #77:

test

# This is the commit message #78:

test

# This is the commit message #79:

test

# This is the commit message #80:

test

# This is the commit message #81:

test

# This is the commit message #82:

test

# This is the commit message #83:

test

# This is the commit message #84:

test

# This is the commit message #85:

test

# This is the commit message #86:

test

# This is the commit message #87:

test

# This is the commit message #88:

test

# This is the commit message #89:

test

# This is the commit message #90:

test1

# This is the commit message #91:

test

# This is the commit message #92:

test

# This is the commit message #93:

test

# This is the commit message #94:

test

# This is the commit message #95:

test

# This is the commit message #96:

test

# This is the commit message #97:

test

# This is the commit message #98:

test

# This is the commit message #99:

test

# This is the commit message #100:

test

# This is the commit message #101:

test

# This is the commit message #102:

test

# This is the commit message #103:

test

# This is the commit message #104:

test

# This is the commit message #105:

test

# This is the commit message #106:

test

# This is the commit message #107:

test

# This is the commit message #108:

test

# This is the commit message #109:

test1

# This is the commit message #110:

test

# This is the commit message #111:

test

# This is the commit message #112:

Test

# This is the commit message #113:

test

# This is the commit message #114:

test

# This is the commit message #115:

test

# This is the commit message #116:

test

# This is the commit message #117:

test

# This is the commit message #118:

test

# This is the commit message #119:

Test

# This is the commit message #120:

Test

# This is the commit message #121:

test

# This is the commit message #122:

test

# This is the commit message #123:

Test

# This is the commit message #124:

test

# This is the commit message #125:

test

# This is the commit message #126:

test

# This is the commit message #127:

test

# This is the commit message #128:

test

# This is the commit message #129:

test

# This is the commit message #130:

test

# This is the commit message #131:

test

# This is the commit message #132:

test

# This is the commit message #133:

test

# This is the commit message #134:

test

# This is the commit message #135:

test

# This is the commit message #136:

test

# This is the commit message #137:

test

# This is the commit message #138:

test

# This is the commit message #139:

test

# This is the commit message #140:

test

# This is the commit message #141:

test

# This is the commit message #142:

test

# This is the commit message #143:

Test

# This is the commit message #144:

Test

# This is the commit message #145:

Test

# This is the commit message #146:

Test

# This is the commit message #147:

test

# This is the commit message #148:

test

# This is the commit message #149:

test

# This is the commit message #150:

test

# This is the commit message #151:

test

# This is the commit message #152:

test

# This is the commit message #153:

test

# This is the commit message #154:

Test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels