Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Video.js v8 #317

Closed
phloxic opened this issue Mar 14, 2023 · 4 comments
Closed

Compatibility with Video.js v8 #317

phloxic opened this issue Mar 14, 2023 · 4 comments

Comments

@phloxic
Copy link

phloxic commented Mar 14, 2023

Is this generator still the recommended way for a plugin project? Are there plans to make it compatible with Video.js v8?

Currently it fails to build working plugins, see for instance phloxic/videojs-sprite-thumbnails#45

I strongly suspect it's because it creates es5 compatible builds, which, apart from breaking, does not make sense with Video.js v8.

@misteroneill
Copy link
Member

It is the recommended way to create a plugin project, but we haven't had time to update it. We are planning to do so in the next month or so, though!

@phloxic
Copy link
Author

phloxic commented Mar 15, 2023

Thanks for the confirmation @misteroneill. I thought as much, just wanted to make sure I don't wait in vain.

@phloxic
Copy link
Author

phloxic commented Apr 1, 2023

@misteroneill - FWIW it looks I can build an es6 plugin by nicking @mr-ben's tip and changing the browserslist in package-json to:

"browserslist": [
  ">0.2%",
  "not dead",
  "not op_mini all",
  "not safari < 10",
  "not chrome < 51",
  "not android < 5",
  "not ie < 12"
],

@phloxic
Copy link
Author

phloxic commented May 11, 2023

This seems to be solved in v9.0.0 without extra gymnastics. Thank you.

Probably for Video.js v7.x one should stick with v8.0.0 of the generator instead of fiddling with the version requirement in package.json?

@phloxic phloxic closed this as completed May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants