Handle 360_CUBE projection #86
Conversation
|
Awesome. Do you have a link to a good sample we can test with? I have some of my own but I'd love to see what you tested against. |
|
Added the cubemap video I've been using for reference under the samples directory. It's just a sample I downloaded and transformed with transform360. The video itself leaves some visible seams on the cube edges for reasons explored in this blog post, which fall on the encoding side. |
src/plugin.js
Outdated
| @@ -387,7 +386,8 @@ class VR extends Plugin { | |||
| this.videoTexture.magFilter = THREE.LinearFilter; | |||
| this.videoTexture.format = THREE.RGBFormat; | |||
|
|
|||
| this.movieMaterial = new THREE.MeshBasicMaterial({ map: this.videoTexture, overdraw: true, side: THREE.FrontSide }); | |||
| // double sided to render inside of cube | |||
| this.movieMaterial = new THREE.MeshBasicMaterial({ map: this.videoTexture, overdraw: true, side: THREE.DoubleSide }); | |||
There was a problem hiding this comment.
It seems like we may just want to put this in this.changeprojection_ and have a separate creation in 360, 360_TR/360_LR, and 360_CUBE. Previously we had this set to DoubleSide but it results in un-needed drawing on the outside of the sphere in 360.
…s to match equirectangular
…s to match equirectangular
|
I paired each projection's I also updated the cubemap faces so they precisely match the equivalent equirectangular video. Just for reference, the cubemap I worked with has the following orientation from the output of transform360: |
|
|
||
| const left = [new THREE.Vector2(0, 0.5), new THREE.Vector2(0.333, 0.5), new THREE.Vector2(0.333, 1), new THREE.Vector2(0, 1)]; | ||
| const right = [new THREE.Vector2(0.333, 0.5), new THREE.Vector2(0.666, 0.5), new THREE.Vector2(0.666, 1), new THREE.Vector2(0.333, 1)]; | ||
| const top = [new THREE.Vector2(0.666, 0.5), new THREE.Vector2(1, 0.5), new THREE.Vector2(1, 1), new THREE.Vector2(0.666, 1)]; |
|
QA LGTM |
No description provided.