Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snapshots #463

Closed
4 tasks done
ilteoood opened this issue Sep 5, 2024 · 4 comments
Closed
4 tasks done

Update snapshots #463

ilteoood opened this issue Sep 5, 2024 · 4 comments

Comments

@ilteoood
Copy link

ilteoood commented Sep 5, 2024

Describe the bug

In the text explorer, update snapshot appears twice.
The first one does nothing, while the second one correctly complete the action
image

Reproduction

Just right click on a test

Output

Clicking on the first `Update Snapshot`, nothing happens

Version

v1.2.1

Validations

@sheremet-va
Copy link
Member

Output

This is not the output

Just right click on a test

This is not a reproduction

I only have a single one. Maybe you have other test runners extensions installed?

Screenshot 2024-09-06 at 13 48 34

Copy link

github-actions bot commented Sep 6, 2024

Hello @ilteoood. Please provide a minimal reproduction using a GitHub repository or StackBlitz (you can also use examples). Issues marked with needs reproduction will be closed if they have no activity within 3 days.

@ilteoood
Copy link
Author

ilteoood commented Sep 6, 2024

@sheremet-va, I know that's not an output. But literally: nothing happens in the vitest's extension logs when I click that button.
Seems to be related to https://marketplace.visualstudio.com/items?itemName=Orta.vscode-jest: if I disable it, it goes away.
It's a curious behaviour, isn't it? The run test functionality is not colliding, but the update snapshot is 🤔

@sheremet-va
Copy link
Member

Vitest should no longer show "Update snapshot" button in other test controllers (e.g., jest). Other controllers need to add the condition themselves like here: cbbb746

@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants