Context buttons at wrong line when returning Promise from test

[rafagsiqueira]

Describe the bug

As shown on the screenshot, the context button (for running the test from the test file) and error messages (from failed expects) is shown at the wrong line, whenever a test returns a Promise.

Reproduction

Test case with the following syntax:

it('just a test', ({expect}) => new Promise<void>((resolve, reject) => {
 resolve();
}

Output

[8:58:59 AM] Marking "just an asynchronous test" as running
[8:59:00 AM] Marking "just an asynchronous test" as passed
[8:59:00 AM] Ending test run projects/etips-utils/search/src/pochettes.service.spec.ts

Version

v1.2.1

Validations

• Check that you are using the latest version of the extension
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[sheremet-va]

Thank you for your answer @andersonsilva87. Would you care to explain the solution instead of sending a zip file? Unfortunately it looks too suspicious.

It is a malicious bot. Please, do not install anything from there.

[sheremet-va]

Output

This is not the full output. Please, provide the full output.

[rafagsiqueira]

@sheremet-va I reported the bot already.
Please see full output below:

[INFO 9:49:54 AM] Running 1 file(s) with name pattern: ^\s?ActionsService just an asynchronous test$
[9:49:54 AM] The runner is starting because tests /Users/rafael/Work/etips/projects/etips-utils/search/src/actions.service.spec.ts were started due to a file change
[9:49:54 AM] Enqueuing "just an asynchronous test
[9:49:55 AM] Marking "should be created" as skipped during collection
[9:49:55 AM] No task result for "just an asynchronous test", assuming the test just started running
[9:49:55 AM] Marking "should load action" as skipped during collection
[9:49:55 AM] Marking "should search actions by month and year of registration" as skipped during collection
[9:49:55 AM] Marking "should search actions by submitter code" as skipped during collection
[9:49:55 AM] Marking "should search actions by participant code" as skipped during collection
[9:49:55 AM] Marking "should search actions by registration number" as skipped during collection
[9:49:55 AM] Marking "should search actions by status" as skipped during collection
[9:49:55 AM] Marking "just an asynchronous test" as running
[9:49:56 AM] Marking "just an asynchronous test" as passed
[9:49:56 AM] Ending test run projects/etips-utils/search/src/actions.service.spec.ts

[rafagsiqueira]

@sheremet-va I realized the minimal repro I sent is not enough. I am trying to reproduce the issue with a new test spec, but couldn't find yet what triggers the unexpected behavior. Will revert back when I find out.

[rafagsiqueira]

I thought removing annotations from test files fixed it, but I can still see instances where the context buttons are in the wrong line of the tests. Still trying to understand what triggers the bug.

[sheremet-va]

Maybe you are using a plugin that produces incorrect source maps. Do you see the error column and line correctly when the test fails in the terminal?

[github-actions]

Hello @rafagsiqueira. Please provide a minimal reproduction using a GitHub repository or StackBlitz (you can also use examples). Issues marked with needs reproduction will be closed if they have no activity within 3 days.

[rafagsiqueira]

@sheremet-va It's an angular application, and it uses @analogjs/vitest-angular:test as the builder.

"test": {
          "builder": "@analogjs/vitest-angular:test",
          "options": {
            "tsConfig": "tsconfig.spec.json",
            "config": "vitest.config.mjs"
          }
        },

Do you think that might be the culprit?
The following test seems to be a minimal reproduction:

import { describe, it } from 'vitest';

describe('ActionsService', () => {

  it('should be created', ({ expect }) => {
    expect(true).toBeTruthy();
  });

  // it('should load action', ({ expect }) => new Promise<void>((resolve, reject) => {
  //   const actionId = '932B0131-29BD-50C0-BB95-0011A8614E71';
  //   const actionGQL = TestBed.inject(ActionGQL);
  // }));

  it('should fail', ({ expect }) => new Promise<void>((resolve, reject) => {
    expect(false).toBeTruthy();
  }));
});

Adding comments to the test seems to do the trick.

[rafagsiqueira]

@sheremet-va found an open issue in their project: analogjs/analog#1211