Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creating and deleting ".." folder wipes storage #65

Closed
OldManYellsAtCloud opened this issue Sep 12, 2021 · 2 comments
Closed

creating and deleting ".." folder wipes storage #65

OldManYellsAtCloud opened this issue Sep 12, 2021 · 2 comments

Comments

@OldManYellsAtCloud
Copy link
Contributor

Creating a folder with the name of ".." (without quotes), and then deleting it will delete the shared storage.

Reproduction:

  1. Connect the device to a Windows PC, and open the shared folder (could work in Linux/Mac also, not sure. Haven't tried.). Have some random files/folders in the storage.
  2. On the Windows machine, in the root folder of the MTP device create a directory called ".." (without quotes). This will create a folder called "New Folder".
  3. Delete the newly created folder in Windows.

Result: the whole content of storage is wiped, including the random files you created in step 1.

@jfdelnero
Copy link
Member

Thanks for reporting/pointing this security issue.
Your scenario case is now fixed.

@OldManYellsAtCloud
Copy link
Contributor Author

Thank you! Will be able to test it and close tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants