Flow warnings

[janpe]

I'm seeing Flow warnings in finnish-business-ids_test.js. Any chance of getting these fixed?

[vkomulai]

Sure thing. I will fix these during today. Thanks for info 👍

[janpe]

Just a friendly reminder that this is still open. 🙂

[vkomulai]

Fixed: 20e38f6

2.0.1 available

[janpe]

Hi again. Seems like the warnings I mentioned (in the finnish-business-ids_test.js) are still there. I get warnings on describe and it. (Could not resolve name) for both.

[vkomulai]

hmm. Could it be something that araises from global eslint? Do you have eslint installed globally?

.eslintrcconfiguration should take care of this - espcieally the mocha part here...

"env": {
    "browser": true,
    "node": true,
    "mocha": true
  }

[janpe]

Here is what flow is giving me:

Error: node_modules/finnish-business-ids/test/finnish-business-ids_test.js:6
  6: describe('finnish-business-ids', () => {
     ^^^^^^^^ identifier `describe`. Could not resolve name

Error: node_modules/finnish-business-ids/test/finnish-business-ids_test.js:9
  9:     it('Should fail when given empty String', () => {
         ^^ identifier `it`. Could not resolve name

Error: node_modules/finnish-business-ids/test/finnish-business-ids_test.js:39
 39:     it('Should fail when given empty String', () => {
         ^^ identifier `it`. Could not resolve name

Error: node_modules/finnish-business-ids/test/finnish-business-ids_test.js:69
 69:     it('Should create valid random business ID with a sample of 10000', () => {
         ^^ identifier `it`. Could not resolve name

Error: node_modules/finnish-business-ids/test/finnish-business-ids_test.js:78
 78:     it('Should create valid random vat number with a sample of 10000', () => {
         ^^ identifier `it`. Could not resolve name

Error: node_modules/finnish-business-ids/test/finnish-business-ids_test.js:87
 87:     it('Should return valid checksum for business ID', () => {
         ^^ identifier `it`. Could not resolve name