Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Pipeline Parallelism support for the Vision Language Models #7684

Open
Manikandan-Thangaraj-ZS0321 opened this issue Aug 20, 2024 · 6 comments · May be fixed by #7168
Open

[Feature]: Pipeline Parallelism support for the Vision Language Models #7684

Manikandan-Thangaraj-ZS0321 opened this issue Aug 20, 2024 · 6 comments · May be fixed by #7168

Comments

@Manikandan-Thangaraj-ZS0321
Copy link
Contributor

Manikandan-Thangaraj-ZS0321 commented Aug 20, 2024

🚀 The feature, motivation and pitch

If I am not wrong, currently vllm supports only the Language models not the Vision models.

NotImplementedError: Pipeline parallelism is only supported for the following architectures: ['AquilaModel', 'AquilaForCausalLM', 'DeepseekV2ForCausalLM', 'InternLMForCausalLM', 'JAISLMHeadModel', 'LlamaForCausalLM', 'LLaMAForCausalLM', 'MistralForCausalLM', 'Phi3ForCausalLM', 'GPT2LMHeadModel', 'MixtralForCausalLM', 'NemotronForCausalLM', 'Qwen2ForCausalLM', 'Qwen2MoeForCausalLM', 'QWenLMHeadModel'].

This feature would greatly benefit teams and projects working with vision-language models, allowing them to scale out their workloads efficiently and maintain performance as model sizes continue to grow.

Also It would be greatly helpful, if someone can point me out on other possibilities for pipeline parallelism. Thanks in advance

Alternatives

No response

Additional context

No response

@youkaichao
Copy link
Member

You can follow #7168 to add some if you want.

@Manikandan-Thangaraj-ZS0321
Copy link
Contributor Author

Manikandan-Thangaraj-ZS0321 commented Aug 21, 2024

Hi @youkaichao,

Thank a lot for the response. I was wondering if there's any way to know when the PR will be merged, as it doesn't seem to be updated with the latest changes from the main branch.

Additionally, could you please suggest any other frameworks that support pipeline parallelism? I need to implement the scale-out (pipeline parallelism) feature in my project as soon as possible.

Thanks again!

@youkaichao
Copy link
Member

that pr #7168 should be merged after @andoorve comes back.

@Manikandan-Thangaraj-ZS0321
Copy link
Contributor Author

@youkaichao, any ideas on frameworks that support pipeline parallelism other than vllm.

@youkaichao
Copy link
Member

any ideas on frameworks that support pipeline parallelism other than vllm

sorry I don't know

@DarkLight1337
Copy link
Member

The rest of the vision language models still don't support PP yet, so I'm reopening this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants