Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Update gptq_marlin to use new vLLMParameters #7281

Merged
merged 14 commits into from
Aug 13, 2024

Conversation

dsikka
Copy link
Contributor

@dsikka dsikka commented Aug 7, 2024

Summary

  • Updates the gptq_marlin parameters to use vLLMParameters to simplify linear layer weight loading
  • Updates to add PackedColumnParameter to support packed parameters without row parallelism

Copy link

github-actions bot commented Aug 7, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@dsikka
Copy link
Contributor Author

dsikka commented Aug 7, 2024

/ready

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 7, 2024
vllm/model_executor/parameter.py Outdated Show resolved Hide resolved
vllm/model_executor/parameter.py Show resolved Hide resolved
vllm/model_executor/parameter.py Outdated Show resolved Hide resolved
vllm/model_executor/parameter.py Outdated Show resolved Hide resolved
@dsikka dsikka requested a review from mgoin August 12, 2024 20:25
@mgoin mgoin merged commit fb377d7 into vllm-project:main Aug 13, 2024
69 checks passed
@mgoin mgoin deleted the update_gptq_params branch August 13, 2024 18:30
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
fialhocoelho pushed a commit to opendatahub-io/vllm that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants