New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not work for charts with image tags that default to Chart.AppVersion #204

Open

petewall opened this issue Oct 4, 2023 · 0 comments

Contributor

petewall commented Oct 4, 2023 •

edited

Loading

I'm seeing more and more Helm charts that leave the tag field empty in favor of defaulting to the AppVersion field of the chart.

A few examples:

Grafana Agent

image:
  # -- Grafana Agent image registry (defaults to docker.io)
  registry: "docker.io"
  # -- Grafana Agent image repository.
  repository: grafana/agent
  # -- (string) Grafana Agent image tag. When empty, the Chart's appVersion is
  # used.
  tag: null

When I run relok8s with the following hints file (I'm using Grafana Agent as a subchart):

---
- "{{ .grafana-agent.image.registry }}/{{ .grafana-agent.image.repository }}:{{ .grafana-agent.image.tag }}"

I get this result:

% relok8s chart move -i hints.yaml --registry registry.exampke.com mychart.tgz
Chart provided
Computing relocation...

Error: failed to pull original images: failed to parse image reference: could not parse reference: docker.io/grafana/agent:<no value>

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment