Service filename bugfix #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevor-vaughan
force-pushed
the
fix_filename_bug
branch
3 times, most recently
from
cb2d810
to
0e73b50
Compare
alexjfisher
reviewed
Mar 6, 2020
alexjfisher
reviewed
Mar 6, 2020
alexjfisher
reviewed
Mar 6, 2020
|
Dear @trevor-vaughan, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
trevor-vaughan
force-pushed
the
fix_filename_bug
branch
from
0e73b50
to
26ec34f
Compare
op-ct
reviewed
Mar 6, 2020
trevor-vaughan
force-pushed
the
fix_filename_bug
branch
from
26ec34f
to
52327e2
Compare
op-ct
reviewed
Mar 7, 2020
This started out as a fix for the custom service filename but spiraled a bit further during debugging. * Auto-correct the filename for firewalld::custom_service * Add a function `firewalld::safe_filename` for munging filenames to safely work with firewalld. The allowed characters were determined by experimentation and are not documented. * Ensure that firewalld_zone resources automatically reload the firewall * Ensure that firewalld_zone names are no longer than 17 characters per the manual * Create firewalld::reload and firewalld::reload::complete classes to allow easier resource chaining * Fix spacing in init.pp * Ensure that all of the Execs that call firewall-cmd happen after the service is running * Ensure that all permanent configuration changes happen before the firewalld service is started/restarted. This is critical if switching from nft to iptables due to the segfault bug in nft * Ensure that all custom service declarations happen before all firewalld_zone resources are triggered. This is automatic in all native types * Updated the service.xml.erb to an EPP file Closes voxpupuli#265
trevor-vaughan
force-pushed
the
fix_filename_bug
branch
from
52327e2
to
c3020fd
Compare
trevor-vaughan
force-pushed
the
fix_filename_bug
branch
from
7883463
to
1be2c90
Compare
|
@bastelfreak Could have sworn that I fixed all of those the first time :-| |
bastelfreak
approved these changes
Mar 8, 2020
|
@bastelfreak The API was not changed and the entire test suite that we have in simp/iptables did not have to be modified at all with these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started out as a fix for the custom service filename but spiraled a
bit further during debugging.
firewalld::safe_filenamefor munging filenames tosafely work with firewalld. The allowed characters were determined by
experimentation and are not documented.
the manual
allow easier resource chaining
service is running
firewalld service is started/restarted. This is critical if switching
from nft to iptables due to the segfault bug in nft
firewalld_zone resources are triggered. This is automatic in all
native types
Closes #265
Pull Request (PR) description
This Pull Request (PR) fixes the following issues