Thank you for your review! I will work on the issues you spotted but it might take a few weeks as i've dug down in some other projects...

As you might have seen i've addressed the issues you spotted but i won't have time to test them properly until some time in august at best.

I just did some real life testing and things seem to work as expected.

I've squished my fixes and rebased on master to remove the merge conflict.

After rebasing the spec tests report an error on my workstation but i don't think it's related as the same error is present in the master branch.

Sorry, i need to fix another thing. The firewalld_policy type insists that ingress and egress zones are arrays which is normally resonable but i don't think it is when ensure is absent.

There, ingress_zone and egress_zone may now be emtpy if ensure is absent.

Can I help get this ready for merge in?

@qha can you squash this down again?

Sorry for being so slow to respond, i was busy going to and recovering from a conference.
If i'm supposed to squash my changes into some other combination of commits i would need more detailed specifications as i feel the current partitioning is the most appropriate and the remote second should be available to whoever merges this with two clicks (squash and merge).
@jcpunk

The main squashing I had in mind was regarding the readme and reference updates. Having the parameter name tweaks in a separate commit may or may not add clarity.

I see. If i recall correctly i did it that way because the reference had not been updated the last few commits so updating it introduced unrelated changes that i did not want to put in the same commit.
Would it help if i updated the reference before the main commit in this pr in one commit and then did so again as part of the main commit?

I see. If i recall correctly i did it that way because the reference had not been updated the last few commits so updating it introduced unrelated changes that i did not want to put in the same commit. Would it help if i updated the reference before the main commit in this pr in one commit and then did so again as part of the main commit?

That is fine with me

I see. If i recall correctly i did it that way because the reference had not been updated the last few commits so updating it introduced unrelated changes that i did not want to put in the same commit. Would it help if i updated the reference before the main commit in this pr in one commit and then did so again as part of the main commit?

That is fine with me

I can't find the other changes i thought i remembered so i just squashed the last commit into the main one.

Unless there are any objections I'd like to merge this in next week.