Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auth][github]: add automatic auth flow to obtain a GitHub token #5

Open
1 of 3 tasks
legomushroom opened this issue Feb 25, 2020 · 1 comment
Open
1 of 3 tasks
Assignees
Labels

Comments

@legomushroom
Copy link
Collaborator

legomushroom commented Feb 25, 2020

When adding a GitHub connector, we ask user for the GitHub PAT to get information about their repo/issues:

image

Currently, there is no way to get that token for the end-user thought. We need to add an authentication flow that will generate GitHub PAT and pass it into the Togezr extension. We can use an Azure Function for the redirection service:

  1. Add the "Please sign in" notification instead of the input.
  2. The GitHub app will redirect to an Azure function endpoint which will exchange the authorization code to the access token.
  3. The Azure function then should redirect to the vscode protocol handler continue the command flow.

Plan:

  • Implement the Azure function.
  • Implement the protocol handler for the extension.
  • Implement the "wait on auth" provider that can be cancelled by the user.

togezr separator

Live Share: Live Share session

legomushroom vsls-bot
legomushroom/github-oauth [ ⇄ master ]

powered by Togezr
@legomushroom legomushroom changed the title [auth][github]: Add automatic auth flow to obtain a GitHub token [auth][github]: add automatic auth flow to obtain a GitHub token Feb 25, 2020
@legomushroom legomushroom added the togezr Better togezr_ label Feb 27, 2020 — with Togezr
Copy link
Collaborator Author

legomushroom commented Feb 28, 2020

legomushroom vsls-bot
togezr separator
🧑‍💻 @legomushroom started Live Share session Live Share session

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant