Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$apollo undefined in SSR #852

Closed
dsanders11 opened this issue Nov 7, 2019 · 2 comments
Closed

$apollo undefined in SSR #852

dsanders11 opened this issue Nov 7, 2019 · 2 comments

Comments

@dsanders11
Copy link

Describe the bug
After c3b840c, any usage of $apollo (such as $apollo.queries.<query>.loading) in templates will result in an error. This is because $apollo will now be null.

@Akryum, is it possible to retain the memory leak fix in c3b840c by only destroying $apollo, without it being set to null?

Versions
vue: 2.6.10
vue-apollo: 3.0.0

@sebmor
Copy link

sebmor commented Nov 7, 2019

+1 Came here to post exactly this

@Akryum Akryum closed this as completed in e6cbaa2 Nov 26, 2019
@Akryum
Copy link
Member

Akryum commented Nov 26, 2019

Test: https://github.com/vuejs/vue-apollo/blob/81b8a4894ab3ebf84f2de030f290604e1e7c26c7/packages/test-ssr/tests/e2e/specs/apollo-ssr.js#L13-L17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants