Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix($theme-default): fix wrong editLink (close: #1115, #1425) #1419

Merged
merged 3 commits into from
Mar 12, 2019

Conversation

shigma
Copy link
Collaborator

@shigma shigma commented Mar 8, 2019

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

#1115, #1125

@shigma shigma requested a review from ulivz March 8, 2019 16:49
+ `/${docsBranch}`
+ (docsDir ? '/' + docsDir.replace(endingSlashRE, '') : '')
+ `/${docsBranch}/`
+ (docsDir ? docsDir.replace(endingSlashRE, '') + '/' : '')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that changes here is unnecessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In past implementations, path is prefixed with a /, however in the pr, path is not prefixed with /. So adding a ending slash is a must.

@shigma shigma changed the title fix($theme-default): fix wrong editLink (close: #1115) fix($theme-default): fix wrong editLink (close: #1115, #1125) Mar 11, 2019
@ulivz ulivz merged commit 3b14375 into master Mar 12, 2019
@ulivz
Copy link
Member

ulivz commented Mar 12, 2019

Here could be a typo, while this pr addressed #1425 instead of #1125.

@shigma shigma deleted the fix-editlink branch March 12, 2019 18:14
@shigma shigma changed the title fix($theme-default): fix wrong editLink (close: #1115, #1125) fix($theme-default): fix wrong editLink (close: #1115, #1425) Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants