Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global config for links attr #358

Merged
merged 2 commits into from
May 8, 2018

Conversation

ycmjason
Copy link
Contributor

@ycmjason ycmjason commented May 7, 2018

Fixing #186

Alternative approach to #356 and #357.

This approach added config.markdown.externalLinks which is an object whose keys and values will be added as a attributes to external links.

cc @ulivz @meteorlxy @mathiasbynens

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer this one, since it looks like more semantic.

@ulivz ulivz merged commit 20e5bd8 into vuejs:master May 8, 2018
@ulivz ulivz mentioned this pull request May 11, 2018
@ulivz
Copy link
Member

ulivz commented May 11, 2018

Will release it at 0.9.0. #419. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants