Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu Button Examples: Change focus indicator to use outline #402

Closed
mcking65 opened this issue Jun 19, 2017 · 1 comment
Closed

Menu Button Examples: Change focus indicator to use outline #402

mcking65 opened this issue Jun 19, 2017 · 1 comment
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern invalid Closed primarily due to error or inaccuracy of some kind

Comments

@mcking65
Copy link
Contributor

In the three menu button examples, per suggestion from @DavidMacDonald in issue #384, change the focus ring to use outline  rather than border.

  1. Navigation menu button
  2. Actions Menu Button Example Using element.focus()
  3. Action Menu Button Example Using aria-activedescendant
@mcking65 mcking65 added bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern labels Jun 19, 2017
@mcking65 mcking65 modified the milestones: 1.1 APG Release 2, 1.1 Rec Jun 19, 2017
@mcking65
Copy link
Contributor Author

@DavidMacDonald, you wrote in issue #384:

You can prevent the page from jiggling as the user tabs by using outline rather than border for the focus ring

The task force has discussed considerations for using both outline and border for the custom focus rings. There are good reasons for either approach. It is possible to use border without any "jiggling" issues. If border is used and elements do get pushed around, we would definitely consider that a bug.

We do not observe any jiggling issues in the 3 menu button examples that use border. If we have overlooked something, please re-open this issue and let us know.

BTW, in issue #590, we plan to offer some guidance on this topic.

@mcking65 mcking65 added the invalid Closed primarily due to error or inaccuracy of some kind label Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern invalid Closed primarily due to error or inaccuracy of some kind
Development

No branches or pull requests

1 participant