Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter tasks sharing some properties and bulk setter #357

Closed
le-jeu opened this issue Apr 22, 2022 · 2 comments
Closed

Filter tasks sharing some properties and bulk setter #357

le-jeu opened this issue Apr 22, 2022 · 2 comments
Labels
In Testing fix is in the code, waiting on verificaiton
Milestone

Comments

@le-jeu
Copy link
Member

le-jeu commented Apr 22, 2022

Some feature requests have in common the need to color all links sharing a property, like the source portal or the assigned agent.
I have some ideas for this:

  1. the Link/Checklist: Filter per zone/comment/agent/state and color filtered (listed) links #318 branch to select a subset of the links in the checklist and color them
  2. integrate buttons (for instance) in the link list (wrt a portal) to color all inbound or outbound links
  3. create a UI to give (client-side) a color to each agent and use this data to color implicitly the rendering
  4. rule base coloring (rendering won't use the color attribute for a link) (see 9d9d1b6 for pin color)

Properties:

  • by assignment
  • by target
  • by source
  • by zone

Related: #318 #335 #350 #191

@cloudkucooland
Copy link
Member

cloudkucooland commented Apr 22, 2022

(1) is the "least surprising" - it is clear what the user wants and does it without realizing that the op data is now more than "just data" but also instructions to the display logic
(2) same - probably the easiest to implement
(3) moderately surprising - would require a change in all clients to display consistently
(4) most surprising - "WHY ARE ALL MY LINKS BLUE!" ... "because you wrote a rule that set all the links to blue...."

@le-jeu
Copy link
Member Author

le-jeu commented Apr 27, 2022

Some more ideas that go more to a new dialog and filter feature with global effect on the UI

Properties:

  • Link/Marker/Both
  • Assignment(s)
  • Portal + From/To/Both
  • State(s)
  • Zone(s)
  • Team (extend assignment)

Actions:

  • Filter in the UI: Map and/or Check/Marker/Link-lists
  • Bulk change:
    • Color
    • State
    • Assignment(s?)
    • Zone
  • Delete

Filter feature:
Given the use case, this can follow CNF pattern. A filter is a conjunction of disjunctions: for each property the task can have some values, and we want the tasks that fill all constraints.
We can be more generic, and have an usual pattern (OR/AND) in UI like data-table-filter_2x_4x.png
or over-engineering it like
https://stackoverflow.com/q/35508800

Note that the filter backend can be generic while the UI is not.
See https://github.com/le-jeu/ingress-intel-total-conversion/blob/5861c0611fe1f6264b2b1fdca16150d939d98d4c/core/code/filters.js as an backend idea (using DNF)

@le-jeu le-jeu changed the title Coloring links sharing some properties Filter tasks sharing some properties and bulk setter Apr 29, 2022
@le-jeu le-jeu added the In Testing fix is in the code, waiting on verificaiton label Apr 30, 2022
@le-jeu le-jeu added this to the 0.22 milestone Oct 9, 2022
@le-jeu le-jeu closed this as completed Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In Testing fix is in the code, waiting on verificaiton
Projects
None yet
Development

No branches or pull requests

2 participants