Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support cacheGroups[key].name function #1653

Closed
Tracked by #3503
9aoy opened this issue Jan 17, 2023 · 6 comments
Closed
Tracked by #3503

support cacheGroups[key].name function #1653

9aoy opened this issue Jan 17, 2023 · 6 comments
Assignees
@JSerFeng
Labels
awaiting more feedback feat New feature or request

Comments

@9aoy
Copy link
Collaborator

9aoy commented Jan 17, 2023 •
edited by h-a-n-a
Loading

needed in splitByModule strategy

https://github.com/web-infra-dev/modern.js/blob/v2.24.0/packages/builder/builder/src/plugins/splitChunks.ts#L169
@hyf0 hyf0 self-assigned this Jan 18, 2023
@IWANABETHATGUY
Copy link
Contributor

IWANABETHATGUY commented Feb 16, 2023 •
edited by h-a-n-a
Loading

options @ahabhgk

@hyf0 hyf0 added the feat New feature or request label Mar 14, 2023
@hyf0 hyf0 added p3-nice-to-have to be discussed Rspack team would discuss these issues per week labels May 9, 2023
@hyf0 hyf0 added this to the Planned milestone May 9, 2023
@IWANABETHATGUY IWANABETHATGUY removed the to be discussed Rspack team would discuss these issues per week label May 9, 2023
@IWANABETHATGUY IWANABETHATGUY modified the milestones: Planned, 0.1.11 - Patch, 0.1.12 - Patch May 9, 2023
@jerrykingxyz jerrykingxyz modified the milestones: 0.1.12 - Patch, 0.1.13 - Patch May 23, 2023
@hyf0 hyf0 removed this from the 0.1.13 - Patch milestone May 31, 2023
@hyf0 hyf0 mentioned this issue Jun 6, 2023
Closed
@hyf0 hyf0 mentioned this issue Jun 16, 2023
Closed
@hyf0
Copy link
Collaborator

hyf0 commented Jun 16, 2023 •
edited
Loading

This blocks

@hardfist
Copy link
Contributor

needed in splitByModule strategy

modern-js-dev/modern.js@main/packages/builder/builder-webpack-provider/src/plugins/splitChunks.ts#L142

link is 404

@9aoy
Copy link
Collaborator Author

9aoy commented Jun 26, 2023

https://github.com/web-infra-dev/modern.js/blob/v2.24.0/packages/builder/builder/src/plugins/splitChunks.ts#L169
updated

@hardfist hardfist assigned JSerFeng and unassigned hyf0 Oct 26, 2023
@xc2
Copy link
Collaborator

xc2 commented Dec 8, 2023 •
edited
Loading

cacheGroups[key].name function token:

  • rspack: (module: Module) => string
  • webpack: <T extends Module>(module: T, selectedChunks: Chunk[], cacheGroupKey: string) => string

related issues:

@chenjiahan
Copy link
Member

This was supported by Rspack.

https://www.rspack.dev/plugins/webpack/split-chunks-plugin.html#splitchunksname

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JSerFeng JSerFeng

Labels
awaiting more feedback feat New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@chenjiahan @hardfist @jerrykingxyz @IWANABETHATGUY @xc2 @9aoy @hyf0 @JSerFeng