Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set watch:false doesn't work #3421

Open
underfin opened this issue Jun 5, 2023 · 3 comments
Open

Set watch:false doesn't work #3421

underfin opened this issue Jun 5, 2023 · 3 comments
Labels
awaiting more feedback bug Something isn't working good first issue Good for newcomers team The issue/pr is created by the member of Rspack.

Comments

@underfin
Copy link
Collaborator

underfin commented Jun 5, 2023

System Info

Details

Expected behavior

Set watch:false should disable rspack watch mode.

Actually behavior

The watch mode also work

Reproduce link

No response

Reproduce Steps

@underfin underfin added bug Something isn't working pending triage The issue/PR is currently untouched. labels Jun 5, 2023
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jun 5, 2023
@hyf0 hyf0 added p3-minor-bug and removed pending triage The issue/PR is currently untouched. labels Jun 5, 2023
@hyf0 hyf0 added this to the Planned milestone Jun 5, 2023
@hardfist hardfist added the good first issue Good for newcomers label Jul 12, 2023
@suica
Copy link
Contributor

suica commented Jul 24, 2023

I cannot reproduce this with 42c51b23, which is a rather new version of code.

Procedure:

  1. cd ./examples/angular/. And in the rspack.config.js, there is already a watch: false, so no need to change config for it.
  2. pnpm run build

After building, the thread exits and the actual output is:

> node scripts/build.js

rspack compiled successfully in 5987 ms
undefined

Any further idea for reproducing this issue? 😲 Or you just mean that watch:false should disable watching when invoked with rspack serve

@stale
Copy link

stale bot commented Sep 22, 2023

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Sep 22, 2023
@hardfist hardfist removed this from the Planned milestone Oct 6, 2023
@stale stale bot removed the stale label Oct 6, 2023
Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting more feedback bug Something isn't working good first issue Good for newcomers team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

No branches or pull requests

5 participants