Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental rebuild should only add the first dependency with the same ResourceIdentifier #4788

Open
h-a-n-a opened this issue Nov 27, 2023 · 1 comment
Assignees
Labels
bug Something isn't working stale team The issue/pr is created by the member of Rspack.

Comments

@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Nov 27, 2023

System Info

@rspack/*: v0.4.0

Details

In incremental rebuild, Rspack pushes multiple dependencies with the same resource identifier into the module factorizer.
The expected behavior is to use resource_identifier to sort dependencies and get the first one for module graph patching.

See:

let mut sorted_dependencies = HashMap::default();

Reproduce link

No response

Reproduce Steps

~

@h-a-n-a h-a-n-a added bug Something isn't working pending triage The issue/PR is currently untouched. and removed pending triage The issue/PR is currently untouched. labels Nov 27, 2023
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Nov 27, 2023
@jerrykingxyz jerrykingxyz self-assigned this Nov 27, 2023
Copy link

stale bot commented Jan 26, 2024

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

No branches or pull requests

2 participants