Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: generated wrong HMR runtime when accepted dependency is not imported before #5597

Closed
h-a-n-a opened this issue Feb 4, 2024 · 2 comments
Assignees
Labels
bug Something isn't working stale team The issue/pr is created by the member of Rspack.

Comments

@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Feb 4, 2024

pass webpack-test/hotCases/worker/move-between-runtime

"./workerA.js": (function (module, __webpack_exports__, __webpack_require__) {
"use strict";
__webpack_require__.r(__webpack_exports__);
/* harmony import */var _worker__WEBPACK_IMPORTED_MODULE_0__ = __webpack_require__(/*! ./worker */"./worker.js");
/* harmony import */var _moduleA__WEBPACK_IMPORTED_MODULE_1__ = __webpack_require__(/*! ./moduleA */"./moduleA.js");


(0, _worker__WEBPACK_IMPORTED_MODULE_0__["default"])(()=>__webpack_require__.e("shared").then(__webpack_require__.bind(__webpack_require__, /*! ./moduleAs */"./moduleAs.js")));
module.hot.accept(/*! ./moduleA */"./moduleA.js", function(){
/* harmony import */_moduleA__WEBPACK_IMPORTED_MODULE_1__ = __webpack_require__(/*! ./moduleA */"./moduleA.js");

});
module.hot.accept(/*! ./moduleAs */"./moduleAs.js", function(){
/* harmony import */_moduleAs__WEBPACK_IMPORTED_MODULE_2__ = __webpack_require__(/*! ./moduleAs */"./moduleAs.js");

});
}),

_moduleAs__WEBPACK_IMPORTED_MODULE_2__ is not defined.

@h-a-n-a h-a-n-a added bug Something isn't working pending triage The issue/PR is currently untouched. labels Feb 4, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Feb 4, 2024
@h-a-n-a h-a-n-a removed the pending triage The issue/PR is currently untouched. label Feb 4, 2024
@h-a-n-a h-a-n-a changed the title [Bug]: generated wrong HMR runtime when variable not exists [Bug]: generated wrong HMR runtime when accepted dependency is not imported before Feb 4, 2024
Copy link

stale bot commented Apr 4, 2024

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@LingyuCoder
Copy link
Collaborator

This is duplicated with #5723, so I will close this issue and track there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

No branches or pull requests

2 participants