Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: detect conflicting values in DefinePlugin #7045

Merged
merged 4 commits into from
Jul 8, 2024
Merged

feat!: detect conflicting values in DefinePlugin #7045

merged 4 commits into from
Jul 8, 2024

Conversation

h-a-n-a
Copy link
Collaborator

@h-a-n-a h-a-n-a commented Jul 4, 2024

Summary

Conflict values in DefinePlugin are being detected.
Previously, if keys were the same, rspack will use the new value to override the previous one.

closes #6821

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@h-a-n-a h-a-n-a added the release: breaking change release: breaking change related release(mr only) label Jul 4, 2024
@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Jul 4, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jul 4, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 4, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 8f2ecb3
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/668bd24f3324990009dd26b2

@ahabhgk ahabhgk enabled auto-merge (squash) July 8, 2024 11:58
@ahabhgk ahabhgk merged commit f2bc023 into main Jul 8, 2024
29 checks passed
@ahabhgk ahabhgk deleted the feat/define-conflict branch July 8, 2024 12:04
@chenjiahan chenjiahan mentioned this pull request Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees

@h-a-n-a h-a-n-a

Labels
release: breaking change release: breaking change related release(mr only) release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: DefinePlugin in webpack will throw a warning for the same key, and rspack will choose to override it.
2 participants
@h-a-n-a @ahabhgk