[Testdriver] bless() does not work if modal dialogs are open

[domenic]

Discovered by @josepharhar. Because bless() appends a button to the root element and then tries to click it, and the root element has been made inert by the modal dialog, this fails.

I'm not sure if there's a good general fix here. You'd need some way of telling what the topmost modal dialog is. dialog:modal will find them all, but among them, which is topmost?

[nt1m]

I'm not sure why we want to fix this personally. You shouldn't try to be clicking an inert element, unless you're explicitly testing that it's not clickable

[josepharhar]

Ideally bless() wouldn't even append or click a button in the first place, but would internally do some sort of user activation thing so that we don't have to worry about the button being clickable in the first place. When I worked around this behavior to make it work when dialogs are open, I didn't even know that there was a button being added or clicked until I read into the implementation and realized that's why this wasn't working.

[domenic]

I'm not sure why we want to fix this personally. You shouldn't try to be clicking an inert element, unless you're explicitly testing that it's not clickable

I'm not trying to click an inert element. I'm trying to bless some API call as having user activation.

Ideally bless() wouldn't even append or click a button in the first place, but would internally do some sort of user activation thing so that we don't have to worry about the button being clickable in the first place.

+1.

[nt1m]

Ah ok, this one is tricky, I wonder if it makes sense to pass an optional element parameter as context or similar. I think it makes some sense since user activation usually comes from somewhere on the page.

[gsnedders]

Ideally bless() wouldn't even append or click a button in the first place, but would internally do some sort of user activation thing so that we don't have to worry about the button being clickable in the first place.

Relatedly: w3c/webdriver-bidi#359