Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive mode produces log that is confusing #41912

Open
WeizhongX opened this issue Sep 11, 2023 · 6 comments
Open

Interactive mode produces log that is confusing #41912

WeizhongX opened this issue Sep 11, 2023 · 6 comments

Comments

@WeizhongX
Copy link
Contributor

Mozlog have an interactive mode (see mozlog/mozlog/formatters/grouping.py), but the log produced at interactive mode is both confusing and incorrect.

Compared the attached log-non-interactive.txt and log-interactive.txt, (they are logs from same command except that for log-non-intertive.txt stdout is redirected to a text file), they are quite different. In log-interactive.txt, we can see a lot of "Restarting browser for new test type" without seeing any test running.

Also attached a video that captures the screen when running the command. I think we should not erase old lines on the screen.

@WeizhongX
Copy link
Contributor Author

@jgraham

@WeizhongX
Copy link
Contributor Author

It would also be nice if we could log the test runner number in the logs.

@jgraham
Copy link
Contributor

jgraham commented Sep 13, 2023

FWIW the grouping formatter originates with @mrobinson's work in Servo.

@mrobinson
Copy link
Contributor

@WeizhongX I think you need to give access to your Google Drive links.

We've made some advancement to the Servo version of this formatter (including fixing some bugs). There are still a few issues to fix. It would be possible to remove the erasing behavior of the formatter, but the idea here is that you can run 1000 tests and follow the failures in real-time without having to look at the scrollback.

@WeizhongX
Copy link
Contributor Author

@mrobinson Thanks, can you request access so that I can grant the permission? I was not able to find your email, and corporate security did not give me an option to share with anybody.

Is it possible for you guys to upstream your side changes?

Our old test runner has a similar feature, which only erases the last line to achieve a similar effect. I plan to upload a video record for that also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants