Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vhal should not be applied to horizontal text #42275

Open
frivoal opened this issue Oct 2, 2023 · 0 comments
Open

vhal should not be applied to horizontal text #42275

frivoal opened this issue Oct 2, 2023 · 0 comments
Assignees

Comments

@frivoal
Copy link
Contributor

frivoal commented Oct 2, 2023

In the following test ref files:

The vhal feature is applied all the time, but I believe it should only be applied in the vertical variant of the test. In other words, unless I am missing something, instead of

halt {
  font-feature-settings: 'halt' 1, 'vhal' 1;
}

we should have

halt {
  font-feature-settings: 'halt' 1;
}
.vrl halt {
  font-feature-settings: 'halt' 1, 'vhal' 1;
}

cc: @kojiishi @fantasai

@frivoal frivoal self-assigned this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants