Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

border-image-image-type-001.htm needs to be improved #42759

Open
TalbotG opened this issue Oct 25, 2023 · 1 comment
Open

border-image-image-type-001.htm needs to be improved #42759

TalbotG opened this issue Oct 25, 2023 · 1 comment
Assignees

Comments

@TalbotG
Copy link
Contributor

TalbotG commented Oct 25, 2023

I have to believe that this test

http://wpt.live/css/css-backgrounds/border-image-image-type-001.htm

https://wpt.fyi/results/css/css-backgrounds/border-image-image-type-001.htm

as designed and as coded is not restrictive enough and is not constrained enough in order to be considered reliable and trustworthy.

See also this review comment in Pull Request 42646

The 4 sliced areas of the border-image should have 2 colors (and not just 1 single uniform filling color like right now) so that we can better check visually if the stretch is done and how the stretch is actually done. One quick way is to paint the middle+central area with a tenth (10th) color so that it will split the 8 sliced areas into 2 distinguishible colors. With inserting
<rect x="5" y="20" width="80" height="70" fill="#FFF8" />
(or
<rect x="5" y="20" width="80" height="70" fill="white" opacity="50%" />
? )
a semi-transparent white-ish rectangular veil at the appropriate line inside the
http://wpt.live/css/css-backgrounds/support/9-colored-areas-40-30-20-10.svg
support SVG image should achieve that reliability goal.

Eg

http://www.gtalbot.org/BrowserBugsSection/CSS3Backgrounds/support/9-colored-areas-40-30-20-10-new.svg

Credits should go to @fantasai for such idea.

@TalbotG TalbotG self-assigned this Oct 25, 2023
@TalbotG
Copy link
Contributor Author

TalbotG commented Nov 22, 2023

What I want to do now is this:

Create a perfectly-equivalent SVG image that is perfectly identical to a .PNG image that was already used in another approved border-image test and then reused its reference file for it. Why? Because I have already spent way too much time trying to work on a test using support/9-colored-areas-40-30-20-10.svg image or using support/9-colored-areas-40-30-20-10-new.svg image and I do not succeed in creating a reliable and trustworthy reference file for it.

The goal and the result of doing the above would create an easy, quick, reliable and trustworthy test (using an SVG image) and its reference file would be already created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant