From c96022939455b494a0c7a1cb8a0d3fc8107ac888 Mon Sep 17 00:00:00 2001 From: Name Date: Wed, 12 Jun 2024 13:36:55 -0400 Subject: [PATCH 1/6] fix waitingforreceipt error --- packages/web3-eth/src/rpc_method_wrappers.ts | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/packages/web3-eth/src/rpc_method_wrappers.ts b/packages/web3-eth/src/rpc_method_wrappers.ts index 336aef3a23d..74dc55ea60c 100644 --- a/packages/web3-eth/src/rpc_method_wrappers.ts +++ b/packages/web3-eth/src/rpc_method_wrappers.ts @@ -496,11 +496,16 @@ export async function getTransactionReceipt( transactionHash, DEFAULT_RETURN_FORMAT, ); - const response = await ethRpcMethods.getTransactionReceipt( - web3Context.requestManager, - transactionHashFormatted, - ); - + let response; + try { + response = await ethRpcMethods.getTransactionReceipt( + web3Context.requestManager, + transactionHashFormatted, + ); + } catch (error) { + console.warn(error) + } + return isNullish(response) ? response : (format( From f4f906019311ef2cbf8d11fedbaf76c93123990d Mon Sep 17 00:00:00 2001 From: Alex Luu Date: Thu, 13 Jun 2024 11:34:52 -0400 Subject: [PATCH 2/6] update cach --- packages/web3-eth/src/web3_eth.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/web3-eth/src/web3_eth.ts b/packages/web3-eth/src/web3_eth.ts index abce5c2c317..dd8e82d0d76 100644 --- a/packages/web3-eth/src/web3_eth.ts +++ b/packages/web3-eth/src/web3_eth.ts @@ -943,9 +943,8 @@ export class Web3Eth extends Web3Context Date: Mon, 17 Jun 2024 12:40:06 -0400 Subject: [PATCH 3/6] remove comment --- packages/web3-eth/src/web3_eth.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/web3-eth/src/web3_eth.ts b/packages/web3-eth/src/web3_eth.ts index dd8e82d0d76..d7d866a229e 100644 --- a/packages/web3-eth/src/web3_eth.ts +++ b/packages/web3-eth/src/web3_eth.ts @@ -944,7 +944,7 @@ export class Web3Eth extends Web3Context Date: Wed, 19 Jun 2024 15:46:19 -0400 Subject: [PATCH 4/6] throw other errors --- packages/web3-eth/src/rpc_method_wrappers.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/web3-eth/src/rpc_method_wrappers.ts b/packages/web3-eth/src/rpc_method_wrappers.ts index 74dc55ea60c..bb3e398e675 100644 --- a/packages/web3-eth/src/rpc_method_wrappers.ts +++ b/packages/web3-eth/src/rpc_method_wrappers.ts @@ -503,7 +503,12 @@ export async function getTransactionReceipt( transactionHashFormatted, ); } catch (error) { - console.warn(error) + if (error.message === 'transaction indexing is in progress') { // this is a geth error, we ignore this and poll till transaction is indexed + console.warn('Transaction indexing is in progress.') + } else { + throw error; + } + } return isNullish(response) From 434538cd67c5221c775bd797c82694164ea40d96 Mon Sep 17 00:00:00 2001 From: Alex Luu Date: Wed, 19 Jun 2024 15:49:40 -0400 Subject: [PATCH 5/6] update changelog and text --- packages/web3-eth/CHANGELOG.md | 6 +++++- packages/web3-eth/src/rpc_method_wrappers.ts | 2 +- packages/web3-eth/src/web3_eth.ts | 3 ++- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/web3-eth/CHANGELOG.md b/packages/web3-eth/CHANGELOG.md index 2b6c0e08005..ba620044bde 100644 --- a/packages/web3-eth/CHANGELOG.md +++ b/packages/web3-eth/CHANGELOG.md @@ -256,4 +256,8 @@ Documentation: - WebEth has `setTransactionMiddleware` and `getTransactionMiddleware` for automatically passing to `sentTransaction` (#7088) - `TransactionMiddleware` and `TransactionMiddleware` data types are exported (#7088) -## [Unreleased] \ No newline at end of file +## [Unreleased] + +### Fixed + +- Fixed geth issue when running a new instance, transactions will index when there are no blocks created (#7098) \ No newline at end of file diff --git a/packages/web3-eth/src/rpc_method_wrappers.ts b/packages/web3-eth/src/rpc_method_wrappers.ts index bb3e398e675..605e718d693 100644 --- a/packages/web3-eth/src/rpc_method_wrappers.ts +++ b/packages/web3-eth/src/rpc_method_wrappers.ts @@ -503,7 +503,7 @@ export async function getTransactionReceipt( transactionHashFormatted, ); } catch (error) { - if (error.message === 'transaction indexing is in progress') { // this is a geth error, we ignore this and poll till transaction is indexed + if (error.message === 'transaction indexing is in progress') { // geth indexing error, we poll until transactions stopped indexing console.warn('Transaction indexing is in progress.') } else { throw error; diff --git a/packages/web3-eth/src/web3_eth.ts b/packages/web3-eth/src/web3_eth.ts index d7d866a229e..abce5c2c317 100644 --- a/packages/web3-eth/src/web3_eth.ts +++ b/packages/web3-eth/src/web3_eth.ts @@ -943,8 +943,9 @@ export class Web3Eth extends Web3Context Date: Wed, 19 Jun 2024 16:01:45 -0400 Subject: [PATCH 6/6] update linter --- packages/web3-eth/src/rpc_method_wrappers.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/web3-eth/src/rpc_method_wrappers.ts b/packages/web3-eth/src/rpc_method_wrappers.ts index 605e718d693..3a03afe0967 100644 --- a/packages/web3-eth/src/rpc_method_wrappers.ts +++ b/packages/web3-eth/src/rpc_method_wrappers.ts @@ -503,7 +503,8 @@ export async function getTransactionReceipt( transactionHashFormatted, ); } catch (error) { - if (error.message === 'transaction indexing is in progress') { // geth indexing error, we poll until transactions stopped indexing + // geth indexing error, we poll until transactions stopped indexing + if (typeof error === 'object' && !isNullish(error) && 'message' in error && (error as { message: string }).message === 'transaction indexing is in progress') { console.warn('Transaction indexing is in progress.') } else { throw error;