Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot execute browser plugin in unloaded node #238

Closed
brollb opened this issue Oct 12, 2020 · 1 comment · Fixed by #250
Closed

Cannot execute browser plugin in unloaded node #238

brollb opened this issue Oct 12, 2020 · 1 comment · Fixed by #250
Assignees

Comments

@brollb
Copy link
Collaborator

brollb commented Oct 12, 2020

I ran into some slightly odd behavior and wanted to make an issue to make sure it was the desired behavior. When running a browser plugin programmatically where the active node is set to a node that has not been loaded by the client, I get an error (Cannot call getOwnRegistry of undefined):
DeepinScreenshot_select-area_20201012172119

If this is the expected behavior, it should at least give a better error message in pluginmanager.js

@kecso
Copy link
Member

kecso commented Oct 15, 2020

I believe this is intended, but you are right in that it should throw a better error telling that you need to have your node ready to call a plugin on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants