Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: graceful exit terminal #3075

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

feat: graceful exit terminal #3075

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
1df8379
feat: graceful exit
rishabh3112 Jan 6, 2022
a87c764
chore: register if cache is available
rishabh3112 Jan 9, 2022
6c8e65a
chore: check cache from options
rishabh3112 Jan 9, 2022
4c66437
chore: rebase
rishabh3112 Jan 9, 2022
d5a1a0d
chore: watch
rishabh3112 Jan 9, 2022
d810c7c
chore: update support for multi compiler
rishabh3112 Jan 11, 2022
4e256a4
chore: create plugin to wait
rishabh3112 Jan 12, 2022
15cd3e8
chore: rebase
rishabh3112 Jan 28, 2022
5dc1863
chore: create config for testing
rishabh3112 Jan 28, 2022
429a46d
chore: update timeout
rishabh3112 Jan 28, 2022
d75d287
chore: update webpack 4 support
rishabh3112 Jan 29, 2022
0991d97
chore: update plugin
rishabh3112 Feb 2, 2022
22e92c4
chore: rebase
rishabh3112 Feb 22, 2022
24a3106
chore: add comment
rishabh3112 Feb 22, 2022
9ea48e7
chore: rebase
rishabh3112 Feb 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: rebase
  • Loading branch information
@rishabh3112
rishabh3112 committed Feb 22, 2022
commit 22e92c4b40d92f87d9b97fc8d9e6f02228aa6da3
18 changes: 11 additions & 7 deletions packages/webpack-cli/src/webpack-cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2496,9 +2496,11 @@ class WebpackCLI implements IWebpackCLI {
return;
}

const isCacheEnabled = compiler.compilers
? compiler.compilers.some((compiler) => compiler.options.cache)
: compiler.options.cache;
const isCacheEnabled = Boolean(
this.isMultipleCompiler(compiler)
? compiler.compilers.some((compiler) => compiler.options.cache)
: compiler.options.cache,
);

let needForceShutdown = false;

Expand Down Expand Up @@ -2526,10 +2528,12 @@ class WebpackCLI implements IWebpackCLI {
});
}

const isWatch = (compiler) =>
compiler.compilers
? compiler.compilers.some((compiler) => compiler.options.watch)
: compiler.options.watch;
const isWatch = (compiler: WebpackCompiler): boolean =>
Boolean(
this.isMultipleCompiler(compiler)
? compiler.compilers.some((compiler) => compiler.options.watch)
: compiler.options.watch,
);

if (isWatch(compiler) && this.needWatchStdin(compiler)) {
process.stdin.on("end", () => {
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.