Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @metamask/sdk version because of the installation hang #3907

Closed
1 task done
hiendaovinh opened this issue May 9, 2024 · 7 comments · Fixed by #3917
Closed
1 task done

Bump @metamask/sdk version because of the installation hang #3907

hiendaovinh opened this issue May 9, 2024 · 7 comments · Fixed by #3917

Comments

@hiendaovinh
Copy link

Describe the bug

wagmi depends on @metamask/sdk but the old version is currently making the installation with npm hang.
MetaMask/metamask-sdk#830

Link to Minimal Reproducible Example

No response

Steps To Reproduce

{
  "dependencies": {
    "react": "^18.3.1",
    "viem": "^2.10.2",
    "wagmi": "^2.8.3"
  }
}
npm cache clean --force
npm install --verbose
34926 silly timing Tried to end timer that doesn't exist: idealTree:#root
34927 silly placeDep ROOT @metamask/sdk-install-modal-web@0.18.5 OK for: @metamask/sdk@0.18.6 want: 0.18.5
34928 silly placeDep ROOT i18next@22.5.1 REPLACE for: @metamask/sdk-install-modal-web@0.18.5 want: 22.5.1
34929 silly placeDep ROOT react-i18next@13.5.0 OK for: @metamask/sdk-install-modal-web@0.18.5 want: ^13.2.2
34930 silly placeDep ROOT qr-code-styling@1.6.0-rc.1 OK for: @metamask/sdk-install-modal-web@0.18.5 want: ^1.6.0-rc.1
34931 silly placeDep ROOT qrcode-generator@1.4.4 OK for: qr-code-styling@1.6.0-rc.1 want: ^1.4.3
34932 silly placeDep ROOT html-parse-stringify@3.0.1 OK for: react-i18next@13.5.0 want: ^3.0.1
34933 silly placeDep ROOT i18next@23.11.3 REPLACE for: react-i18next@13.5.0 want: >= 23.2.3
34934 silly timing Tried to end timer that doesn't exist: idealTree:#root
34935 silly placeDep ROOT @metamask/sdk-install-modal-web@0.18.5 OK for: @metamask/sdk@0.18.6 want: 0.18.5
34936 silly placeDep ROOT i18next@22.5.1 REPLACE for: @metamask/sdk-install-modal-web@0.18.5 want: 22.5.1
34937 silly placeDep ROOT react-i18next@13.5.0 OK for: @metamask/sdk-install-modal-web@0.18.5 want: ^13.2.2
34938 silly placeDep ROOT qr-code-styling@1.6.0-rc.1 OK for: @metamask/sdk-install-modal-web@0.18.5 want: ^1.6.0-rc.1
34939 silly placeDep ROOT qrcode-generator@1.4.4 OK for: qr-code-styling@1.6.0-rc.1 want: ^1.4.3
34940 silly placeDep ROOT html-parse-stringify@3.0.1 OK for: react-i18next@13.5.0 want: ^3.0.1
34941 silly placeDep ROOT i18next@23.11.3 REPLACE for: react-i18next@13.5.0 want: >= 23.2.3
34942 silly timing Tried to end timer that doesn't exist: idealTree:#root
34943 silly placeDep ROOT @metamask/sdk-install-modal-web@0.18.5 OK for: @metamask/sdk@0.18.6 want: 0.18.5
34944 silly placeDep ROOT i18next@22.5.1 REPLACE for: @metamask/sdk-install-modal-web@0.18.5 want: 22.5.1
34945 silly placeDep ROOT react-i18next@13.5.0 OK for: @metamask/sdk-install-modal-web@0.18.5 want: ^13.2.2
34946 silly placeDep ROOT qr-code-styling@1.6.0-rc.1 OK for: @metamask/sdk-install-modal-web@0.18.5 want: ^1.6.0-rc.1
34947 silly placeDep ROOT qrcode-generator@1.4.4 OK for: qr-code-styling@1.6.0-rc.1 want: ^1.4.3
34948 silly placeDep ROOT html-parse-stringify@3.0.1 OK for: react-i18next@13.5.0 want: ^3.0.1
34949 silly placeDep ROOT i18next@23.11.3 REPLACE for: react-i18next@13.5.0 want: >= 23.2.3
34950 silly timing Tried to end timer that doesn't exist: idealTree:#root
34951 silly placeDep ROOT @metamask/sdk-install-modal-web@0.18.5 OK for: @metamask/sdk@0.18.6 want: 0.18.5
34952 silly placeDep ROOT i18next@22.5.1 REPLACE for: @metamask/sdk-install-modal-web@0.18.5 want: 22.5.1
34953 silly placeDep ROOT react-i18next@13.5.0 OK for: @metamask/sdk-install-modal-web@0.18.5 want: ^13.2.2
34954 silly placeDep ROOT qr-code-styling@1.6.0-rc.1 OK for: @metamask/sdk-install-modal-web@0.18.5 want: ^1.6.0-rc.1
34955 silly placeDep ROOT qrcode-generator@1.4.4 OK for: qr-code-styling@1.6.0-rc.1 want: ^1.4.3
34956 silly placeDep ROOT html-parse-stringify@3.0.1 OK for: react-i18next@13.5.0 want: ^3.0.1
34957 silly placeDep ROOT i18next@23.11.3 REPLACE for: react-i18next@13.5.0 want: >= 23.2.

Wagmi Version

2.8.3

Viem Version

2.10.2

TypeScript Version

No response

Check existing issues

Anything else?

No response

@samedayjeremy
Copy link

I'm experiencing this too. Best workaround for this?

@navFooh
Copy link

navFooh commented May 10, 2024

For me it works to use React 18.2.0 for now. That also throws warnings about package conflicts with @metamask/sdk, but it does install. So hoping the @metamask/sdk package gets updated soon 🤞

@jxom
Copy link
Member

jxom commented May 10, 2024

There is a bug in the latest MetaMask SDK version which prevents it to run. We will update to the latest MetaMask SDK version when it is stable. ☺️

@hiendaovinh
Copy link
Author

hiendaovinh commented May 10, 2024

@jxom They already fixed that after I reported: MetaMask/metamask-sdk#833

Would you mind if I create a pull request to bump the version?

@eliobricenov
Copy link

@jxom I can't install wagmi because of this error. Any workaround that isn't using a different package manager?

@eliobricenov
Copy link

Working fine thank you @jxom.

Copy link
Contributor

This issue has been locked since it has been closed for more than 14 days.

If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest Wagmi version. If you have any questions or comments you can create a new discussion thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants