Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rip offset find seems to fail #4

Closed
abendebury opened this issue Dec 11, 2015 · 3 comments
Closed

rip offset find seems to fail #4

abendebury opened this issue Dec 11, 2015 · 3 comments
Labels
Bug Generic bug: can be used together with more specific labels
Milestone
1.0

Comments

@abendebury
Copy link

https://what.cd/forums.php?action=viewthread&threadid=163034&postid=5702764#post5702764
@JoeLametta
Copy link
Collaborator

This one was fixed with the following commit: 1d046c6
I'm keeping this one open because the solution can be hopefully improved

@JoeLametta JoeLametta added the Bug Generic bug: can be used together with more specific labels label Dec 11, 2015
@abendebury
Copy link
Author

What's wrong with this solution?

@abendebury abendebury modified the milestone: 1.0 Dec 13, 2015
@JoeLametta
Copy link
Collaborator

I'm closing this one: the fix is ok but, in the long term, the offset.py code should be restructured in a way that takes advantage of the overreading feature currently available (of course this is very low priority).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Generic bug: can be used together with more specific labels
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@abendebury @JoeLametta