Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace spaces in artist/album/track name with underscore or other custom character #405

Closed
robguinness opened this issue Jun 14, 2019 · 4 comments
Labels
Duplicate Duplicate of another issue Feature New feature

Comments

@robguinness
Copy link

Hi, I just discovered whipper today. I didn't find an option to replace spaces in the artist/album/track data that comes from MusicBrainz with some other character (e.g. _) for use in directory/filenames. I was thinking about making a PR to add this as an option. Would that be something others are interested in?

@welcome
Copy link

welcome bot commented Jun 14, 2019

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing instructions.

@walterav1984
Copy link

I'm interested, maybe combine it with an option for limiting even more simple filesystem unfriendly characters or filename lengths.

@smithbone
Copy link

+1 for this feature as well.

@JoeLametta JoeLametta added Duplicate Duplicate of another issue Feature New feature labels Nov 28, 2019
@JoeLametta
Copy link
Collaborator

Hi @robguinness, sorry for the late reply. I think that what you're asking is already being worked on (in #324). A similar discussion already happened in #313 so I'll close this issue in favour of #313 (if you think this is wrong, feel free to reopen the issue).

Cheers,
Joe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate Duplicate of another issue Feature New feature
Projects
None yet
Development

No branches or pull requests

4 participants