Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: Transfer Rate MBps or Mbps? #242

Closed
rajeshisnepali opened this issue May 28, 2020 · 2 comments · Fixed by #245
Closed

Question: Transfer Rate MBps or Mbps? #242

rajeshisnepali opened this issue May 28, 2020 · 2 comments · Fixed by #245

Comments

@rajeshisnepali
Copy link

android_file_transfer_transfer_rate

I have a question. Was that MBps or Mbps?

Before the app, I use to use FTP for transferring larger files. I was getting 25-27 MBps via nautilus (< 1GB files).

Please let me know.
@whoozle
Copy link
Owner

whoozle commented Jun 7, 2020 •
edited
Loading

It's megabytes with base of 1000. I have a feeling that it should be fixed, because it's misleading and gives wrong impression of speed

Please find piece of code which updates progress dialogue:

	static constexpr double Kb = 1000;
	static constexpr double Mb = 1000 * Kb; //haha
	static constexpr double Gb = 1000 * Mb;
	if (speed < 2 * Mb)
		ui->speedLabel->setText(tr("Speed: %1 Kb/s").arg(speed / Kb, 0, 'f', 1));
	else if (speed < 2 * Gb)
		ui->speedLabel->setText(tr("Speed: %1 Mb/s").arg(speed / Mb, 0, 'f', 1));
	else
		ui->speedLabel->setText(tr("Speed: %1 Gb/s").arg(speed / Gb, 0, 'f', 1));

@rajeshisnepali
Copy link
Author

I have installed it via the Ubuntu Store. So I don't think I've much option to configure. Better is to wait until the issue is fixed.

Please fix it soon. Thanks.

@huupoke12 huupoke12 mentioned this issue Sep 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix unit usage
2 participants
@whoozle @rajeshisnepali