Missing Version number in latest release

[suschizu]

Hey @whoozle - I just noticed that the version number is missing in the 4.2 mac download
(https://github.com/whoozle/android-file-transfer-linux/releases/download/v4.2/AndroidFileTransferForLinux.dmg)

[core-code]

i can confirm this. both the CFBundleVersion and CFBundleShortVersion entries are missing from the Info.plist file

[core-code]

this is a regression. version 4.0 did contain the CFBundleVersion

[yurikoles]

I also confirm this.

[yurikoles]

https://developer.apple.com/library/archive/qa/qa1827/_index.html

[suschizu]

Version 4.3 again doesn't contain a version number :(

[whoozle]

Can you check the latest contiguous release? If it works for you, I'll release new version soon

[yurikoles]

It's fixed now, thanks!

[whoozle]

Awesome, thanks for the fast reply!

This was something plaguing macosx builds for quite some time, I even refactored old plist into cmake-based one at some point, but overlooked that version variables were named differently than in the root cmake file 😱

[core-code]

thanks for the progress here!

just FYI if you are already working on it the Get Info String (CFBundleGetInfoString) has been deprecated for ~15 years and should be removed. if you want to add copyright info the NSHumanReadableCopyright is the right place

[whoozle]

removed in f20e240 thanks :)

Can you take a look at
https://github.com/whoozle/android-file-transfer-linux/blob/master/qt/Info.plist.in
Maybe you can spot something obvious

[core-code]

basically looks good.

CFBundleLongVersionString

i think that one has been deprecated even back when Mac OS X was first released in 2001, so you can definitely drop it.

CFBundleDisplayName
Android File Transfer for Linux and MacOSX

that changes the name under which the app shows up in the Finder so i'd recommend shortening it to 'Android File Transfer'.

if you really want to include the OSes it runs on (why?),"MacOSX" should be changed to "macOS" to match the official name these days.