Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchies are still weird #332

Open
3 tasks
dphiffer opened this issue Oct 4, 2017 · 3 comments
Open
3 tasks

Hierarchies are still weird #332

dphiffer opened this issue Oct 4, 2017 · 3 comments
Assignees

Comments

@dphiffer
Copy link
Member

dphiffer commented Oct 4, 2017

I've noticed a handful of weird things happening with hierarchy/parent assignment in BI. This is a catch-all issue to account for them.

  • make the wof:parent_id field writeable
  • venues should get assigned localities as parents if there's no neighbourhood in the hierarchy
  • other things?
@stepps00
Copy link
Member

stepps00 commented Oct 9, 2017

I added reversegeo:* properties to the record of Basse Terre and update the record's hierarchy, here. This worked as expected, but the wof:parent_id was not reset. I think this touches the first point, "make the wof:parent_id field writeable".

@stepps00
Copy link
Member

https://whosonfirst.mapzen.com/boundaryissues/id/1158844415/#16/37.3144/-121.8657

I added this record via BI and it received a dual hierarchy:

'wof:hierarchy': [{u'continent_id': 102191575,
                     u'country_id': 85633793,
                     u'county_id': 102081673,
                     u'locality_id': 85922347,
                     u'macrohood_id': 1108782557,
                     u'neighbourhood_id': 1108784971,
                     u'region_id': 85688637,
                     u'venue_id': 1158844415},

                    {u'continent_id': 102191575,
                     u'country_id': 85633793,
                     u'county_id': 102081673,
                     u'locality_id': 85922347,
                     u'neighbourhood_id': 85887655,  <--
                     u'region_id': 85688637,
                     u'venue_id': 1158844415}],

The second hierarchy includes a deprecated/non-current neighbourhood record. The first hierarchy is correct, but records tagged as non-current shouldn't be used to build hierarchies.

@stepps00
Copy link
Member

Noting that the wof:parent_id property is now editable, but not re-populated when a hierarchy is rebuilt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants