From d65803f2a595c0706659185d53c93056a2d08b99 Mon Sep 17 00:00:00 2001
From: Ed Sanders <ejsanders@gmail.com>
Date: Wed, 9 Dec 2020 12:20:01 +0000
Subject: [PATCH] Add tests for languages/es5

---
 test/fixtures/client-es5/invalid.js | 65 +++++++++++++++++++++++++++--
 test/fixtures/client-es5/valid.js   |  6 +++
 test/test.js                        |  9 ++++
 3 files changed, 76 insertions(+), 4 deletions(-)

diff --git a/test/fixtures/client-es5/invalid.js b/test/fixtures/client-es5/invalid.js
index 699b49d9..b51465f9 100644
--- a/test/fixtures/client-es5/invalid.js
+++ b/test/fixtures/client-es5/invalid.js
@@ -7,16 +7,61 @@
 	document.appendChild( node.parentElement );
 
 	// not-es5
+	// The following features already trigger parser errors
+	// <!-- eslint-disable-next-line es-x/no-arrow-functions -- >
+	// <!-- eslint-disable-next-line es-x/no-binary-numeric-literals -->
+	// <!-- eslint-disable-next-line es-x/no-block-scoped-functions -->
+	// <!-- eslint-disable-next-line es-x/no-block-scoped-variables -->
+	// <!-- eslint-disable-next-line es-x/no-classes -- >
+	// <!-- eslint-disable-next-line es-x/no-computed-properties -- >
+	// <!-- eslint-disable-next-line es-x/no-default-parameters -- >
+	// <!-- eslint-disable-next-line es-x/no-destructuring -- >
+	// <!-- eslint-disable-next-line es-x/no-for-of-loops -- >
+	// <!-- eslint-disable-next-line es-x/no-generators -- >
+	// <!-- eslint-disable-next-line es-x/no-modules -- >
+	// <!-- eslint-disable-next-line es-x/no-new-target -- >
+	// <!-- eslint-disable-next-line es-x/no-object-super-properties -- >
+	// <!-- eslint-disable-next-line es-x/no-octal-numeric-literals -- >
+	// <!-- eslint-disable-next-line es-x/no-property-shorthands -- >
+	// <!-- eslint-disable-next-line es-x/no-regexp-prototype-flags -- >
+	// <!-- eslint-disable-next-line es-x/no-regexp-u-flag -- >
+	// <!-- eslint-disable-next-line es-x/no-regexp-y-flag -- >
+	// <!-- eslint-disable-next-line es-x/no-rest-parameters -- >
+	// <!-- eslint-disable-next-line es-x/no-spread-elements -- >
+	// <!-- eslint-disable-next-line es-x/no-subclassing-builtins -- >
+	// <!-- eslint-disable-next-line es-x/no-template-literals -- >
+	// <!-- eslint-disable-next-line es-x/no-unicode-codepoint-escapes -- >
+	// Globals which won't exist
+	// <!-- eslint-disable-next-line es-x/no-map -- >
+	// <!-- eslint-disable-next-line es-x/no-promise -- >
+	// <!-- eslint-disable-next-line es-x/no-proxy -- >
+	// <!-- eslint-disable-next-line es-x/no-reflect -- >
+	// <!-- eslint-disable-next-line es-x/no-set -- >
+	// <!-- eslint-disable-next-line es-x/no-symbol -- >
+	// <!-- eslint-disable-next-line es-x/no-typed-arrays -- >
+	// <!-- eslint-disable-next-line es-x/no-weak-map -- >
+	// <!-- eslint-disable-next-line es-x/no-weak-set -- >
+
+	// eslint-disable-next-line es-x/no-array-from
+	Array.from();
+	// eslint-disable-next-line es-x/no-array-of
+	Array.of();
+	// eslint-disable-next-line es-x/no-array-prototype-copywithin
+	[].copyWithin();
+	// eslint-disable-next-line es-x/no-array-prototype-fill
+	[].fill();
+	// eslint-disable-next-line es-x/no-array-prototype-findindex
+	[].findIndex();
+	// eslint-disable-next-line es-x/no-array-prototype-keys
+	[].keys();
+	// eslint-disable-next-line es-x/no-array-prototype-values
+	[].values();
 	// eslint-disable-next-line es-x/no-string-prototype-codepointat
 	''.codePointAt();
 	// eslint-disable-next-line es-x/no-array-prototype-keys
 	[].keys();
 	// eslint-disable-next-line es-x/no-array-prototype-entries
 	[].entries();
-	// eslint-disable-next-line es-x/no-array-from
-	Array.from();
-	// eslint-disable-next-line es-x/no-array-of
-	Array.of();
 	// eslint-disable-next-line es-x/no-math-acosh
 	Math.acosh();
 	// eslint-disable-next-line es-x/no-math-asinh
@@ -75,8 +120,20 @@
 	Object.getOwnPropertySymbols();
 	// eslint-disable-next-line es-x/no-object-is
 	Object.is();
+	// eslint-disable-next-line es-x/no-object-setprototypeof
+	Object.setPrototypeOf();
 	// eslint-disable-next-line es-x/no-string-fromcodepoint
 	String.fromCodePoint();
+	// eslint-disable-next-line es-x/no-string-prototype-endswith
+	''.endsWith();
+	// eslint-disable-next-line es-x/no-string-prototype-includes
+	''.includes();
+	// eslint-disable-next-line es-x/no-string-prototype-normalize
+	''.normalize();
+	// eslint-disable-next-line es-x/no-string-prototype-repeat
+	''.repeat();
+	// eslint-disable-next-line es-x/no-string-prototype-startswith
+	''.startsWith();
 	// eslint-disable-next-line es-x/no-string-raw
 	String.raw();
 
diff --git a/test/fixtures/client-es5/valid.js b/test/fixtures/client-es5/valid.js
index d443522a..355c0a7f 100644
--- a/test/fixtures/client-es5/valid.js
+++ b/test/fixtures/client-es5/valid.js
@@ -1 +1,7 @@
 /* eslint-env browser */
+( function () {
+	var $div;
+	// [].find should be disabled, but it conflicts with jQuery
+	// Off: es-x/no-array-prototype-find
+	$div.find();
+}() );
diff --git a/test/test.js b/test/test.js
index 0140e9f4..c898f89e 100644
--- a/test/test.js
+++ b/test/test.js
@@ -143,6 +143,15 @@ configs.forEach( ( configPath ) => {
 			);
 		}
 
+		if ( configName === 'client-es5' ) {
+			// Load the rules for ES5 when testing client
+			Object.assign(
+				rules,
+				getRules( require( 'eslint-plugin-es-x/lib/configs/no-new-in-es2015' ) ),
+				getRules( require( '../language/es5' ) )
+			);
+		}
+
 		if ( upstreamConfigsToTest.includes( configName ) ) {
 			const extendsConfig = getPluginExtends( config );
 			rules = Object.assign( {}, extendsConfig.rules, rules );