-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syslog levels regression #249
Comments
+1 |
The syslog-commit has the wrong semantic. It disabled our logging. Together with node 0.10-issues it was complicate to debug. Because of the wrong npm-levels (which would be corrected) I think many people use |
+1. This is very confusing now. |
+1 on needing a way around this. Setting log level to 'info' usually means you want info, notice, warning ... Now Winston will give you info and debug but not the rest. |
+1. Working around this by setting log level to 'emerg'. |
@airandfingers By setting log level to emerg, you get all log messages to be sent to syslog, right? |
@julien51 Correct. |
+1 on reversing the order. I just wasted too much time tracking this down :/ |
This absolutely a regression. There is a larger discussion of how we will fix this in #406. Closing this as a duplicate. |
The last commit on the syslog levels reversed the order which breaks how Winston limits log severity. Winston tracks more verbose as being a smaller value normally, and depends on this. Swapping so that debug is a higher value means that debug level is always logged and critical or errors are not logged if you were to set the log level to "info" for example.
651b13e#commitcomment-3163605
The text was updated successfully, but these errors were encountered: