Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPG key support #1

Open
woalk opened this issue Mar 25, 2018 · 0 comments
Open

GPG key support #1

woalk opened this issue Mar 25, 2018 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@woalk
Copy link
Owner

woalk commented Mar 25, 2018

Implement support of GPG key switching based on identity.

GPG keys are also part of an identity and one may not want to commit with the wrong or without GPG key if you have a key for your identity.

  • The key should be optional when calling git identities add <id> <name> <email> [<gpg-id>]
  • The key should be changeable with git identities update --key <gpg-id>
  • The key should be checked when searching for the currently selected identity (most importantly in checks.py):
    • If no key is set, but name and email match an identity with a key (and the same identity does not exist with a key as well), it should be shown as an error and not be committable. It should be shown as a warning in list and show (e.g. mark the selected identity with an exclamation mark instead of an askerisk).
    • If a key is set, but name and email match an identity without key (and the same identity doesn't exist without key), it should also be treated that way.
  • When changing from an identity with a key to an identity without key, the selected key config should be removed.

There's room for discussion on what to check for correct key use.
Suggest commit -S aliases, switch git log aliases to automatically include GPG information based on the repo context, etc.

@woalk woalk added the enhancement New feature or request label Mar 25, 2018
@woalk woalk self-assigned this Mar 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant