Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wolfi Package Request]: iptables-wrapper #24440

Open
4 tasks done
sgalsaleh opened this issue Jul 22, 2024 · 2 comments · May be fixed by #24497
Open
4 tasks done

[Wolfi Package Request]: iptables-wrapper #24440

sgalsaleh opened this issue Jul 22, 2024 · 2 comments · May be fixed by #24497
Labels
needs-triage applied to all new customer/user issues. Removed after triage occurs. wolfi-package-request used to track requests for new wolfi packages

Comments

@sgalsaleh
Copy link

sgalsaleh commented Jul 22, 2024

What software would you like us to add to wolfi-os. Ideally include a URL to the project and its source.

https://github.com/kubernetes-sigs/iptables-wrappers/
https://raw.githubusercontent.com/kubernetes-sigs/iptables-wrappers/v2/iptables-wrapper-installer.sh

which versions of the software should we include?

v2

Add some justification for why this specific package and versions are important.

The wrapper script and the iptables-wrapper binary seem to be required to support ipv6 in kube-proxy. When trying to use the kube-proxy Wolfi package with just the ip6tables and iptables packages, kube-proxy complains with the following:

...
server_others.go:146] "No iptables support for family" ipFamily="IPv6"
server.go:654] "kube-proxy running in single-stack mode" ipFamily="IPv4"
...

I noticed that the cilium package includes that wrapper script, so I tried adding the cilium-iptables package, and kube-proxy was able to detect ipv6 support:

...
server.go:652] "kube-proxy running in dual-stack mode" primary ipFamily="IPv4"
...

Would it be possible to add this wrapper script and the iptables-wrapper binary as a separate package or a sub-package for the kube-proxy package and have it come from the official Kubernetes project here instead? Kubernetes includes that in the build process for kube-proxy here.

Thanks in advance!

Please check all that apply

  • This package has an un-restrictive license
  • The package/versions proposed are actively maintained upstream
  • I am interested in adding this package to Wolfi OS myself
  • I am willing to help maintain this package
@sgalsaleh sgalsaleh added needs-triage applied to all new customer/user issues. Removed after triage occurs. wolfi-package-request used to track requests for new wolfi packages labels Jul 22, 2024
@sgalsaleh sgalsaleh changed the title [Wolfi Package Request]: iptables-wrapper-installer.sh [Wolfi Package Request]: iptables-wrapper Jul 22, 2024
@tuananh
Copy link
Contributor

tuananh commented Jul 23, 2024

i think it's better off as separated package because the src code to build is not coming from kube-proxy. they just include it in kube-proxy image.

@sgalsaleh
Copy link
Author

Makes sense.

@sgalsaleh sgalsaleh linked a pull request Jul 23, 2024 that will close this issue
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage applied to all new customer/user issues. Removed after triage occurs. wolfi-package-request used to track requests for new wolfi packages
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants