Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use undefined instead of null #107

Closed
hvge opened this issue Sep 20, 2022 · 1 comment
Closed

Use undefined instead of null #107

hvge opened this issue Sep 20, 2022 · 1 comment
Assignees
@hvge
Labels
bug
Milestone
2.3.0

Comments

@hvge
Copy link
Member

hvge commented Sep 20, 2022 •
edited
Loading

We should prefer undefined over null. See TS coding guidelines.
@hvge hvge added this to the 2.3.0 milestone Sep 20, 2022
@hvge hvge self-assigned this Sep 20, 2022
@hvge hvge added bug and removed enhancement labels Sep 26, 2022
@hvge
Copy link
Member Author

hvge commented Sep 26, 2022

Changed classification to bug. My new e2e tests revealed that null is actually mapped to NSNull in iOS implementation and therefore the current implementation in develop branch crashes on various places.

@hvge hvge mentioned this issue Oct 10, 2022
Merged
@hvge hvge closed this as completed in 5dc4dc4 Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hvge hvge

Labels
bug
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
1 participant
@hvge