Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Palettized volume texture format conversion is unimplemented #567

Closed
Triticum0 opened this issue Nov 23, 2021 · 4 comments · Fixed by #685
Closed

Palettized volume texture format conversion is unimplemented #567

Triticum0 opened this issue Nov 23, 2021 · 4 comments · Fixed by #685
Labels
bug Something isn't working

Comments

@Triticum0
Copy link

Triticum0 commented Nov 23, 2021

Title

https://xemu.app/titles/4a410006/#Room-Zoom-Race-for-Impact

Bug Description

When trying to go in-game the game crashes with this assertion:
https://github.com/mborgerson/xemu/blob/5faa2419e7cfca1e03a8e3113de2df6453caf2e5/hw/xbox/nv2a/pgraph.c#L6368

Expected Behavior

Should be able to make it in-game

xemu Version

Version: 0.6.2
Branch: master
Commit: 5faa241
Date: Sat Nov 20 08:53:11 UTC 2021
Last-known Working: Unknown

System Information

Field Value
OS Ubuntu 20.04.3 LTS
CPU Intel(R) Pentium(R) CPU 3825U @ 1.90GHz
Graphics Device Mesa Intel(R) HD Graphics (BDW GT1)
Graphics Driver Drivers: 4.6 (Core Profile) Mesa 21.0.3

Additional Context

Also NV097_SET_TEXTURE_FORMAT_COLOR_LC_IMAGE_CR8YB8CB8YA8,YB8CR8YA8CB8 and NV097_SET_TEXTURE_FORMAT_COLOR_SZ_R6G5B5) should properly also be fixed even through there no known use case for these assertions.
Edit: Tested on lasted build still crashes

@Triticum0 Triticum0 added the bug Something isn't working label Nov 23, 2021
@Ernegien
Copy link
Contributor

This would be a good starting point for unit-testing, which I may do later :)

@mborgerson mborgerson changed the title Room Zoom: Race for Impact convert_texture_data for NV097_SET_TEXTURE_FORMAT_COLOR_SZ_I8_A8R8G8B8 is incorrect Palettized volume texture format conversion is unimplemented Nov 23, 2021
@dracc
Copy link
Contributor

dracc commented Nov 24, 2021

I haven't inspected code, issue is probably still present, but please consider updating your xemu - 0.5.0 is quite old by now.

@Triticum0
Copy link
Author

Triticum0 commented Nov 24, 2021

@dracc I tested on masters, still crashes with the same assertion

@abaire
Copy link
Contributor

abaire commented Jan 27, 2022

Parameters when it asserts:

s.color_format == NV097_SET_TEXTURE_FORMAT_COLOR_SZ_I8_A8R8G8B8

width = 128
height = 128
depth = 32
row_pitch = 128
slice_pitch = 16384

palette data looks like it's at least pointing at something structured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants