Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert USB Speed string to an enum #110

Open
mbanth opened this issue Mar 23, 2021 · 0 comments
Open

Convert USB Speed string to an enum #110

mbanth opened this issue Mar 23, 2021 · 0 comments
Labels
enhancement New feature or request testing Issue with testing

Comments

@mbanth
Copy link
Contributor

mbanth commented Mar 23, 2021

In a comment in Pull Request #103, @xross suggests representing the usb_speed in helpers.py as an enum. Because the tests currently use Python 2.7 which does not include enums as part of the language, we have decided to defer this enhancement.

Python 3.4 and later versions support enums. Once the tests have made the transition from Python 2.7 to Python 3.4 or later (almost certainly 3.7 or later), we can convert usb_speed from a string to an enum.

Issue #83 tracks the transition from Python 2 to Python 3.

@mbanth mbanth added enhancement New feature or request testing Issue with testing labels Mar 23, 2021
@mbanth mbanth added this to the Publish Before Resolution milestone Apr 8, 2021
@mbanth mbanth removed this from the Publish Before Resolution milestone Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing Issue with testing
Projects
None yet
Development

No branches or pull requests

1 participant