Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace clap with lexopt in mls_validation_service #1109

Open
insipx opened this issue Oct 3, 2024 · 1 comment
Open

Replace clap with lexopt in mls_validation_service #1109

insipx opened this issue Oct 3, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers perf

Comments

@insipx
Copy link
Contributor

insipx commented Oct 3, 2024 •
edited
Loading

Clap is a huge dependency with lots of different features used by mls_validation_service to parse only 2 command line flags. We can instead use lexopt which is a much smaller dependency that achieves the same ergonomics but without the compile time

picoargs also a contender
@insipx insipx added enhancement New feature or request good first issue Good for newcomers perf labels Oct 3, 2024
@neekolas
Copy link
Contributor

neekolas commented Oct 3, 2024

Love it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers perf
Projects
libxmtp
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neekolas @insipx