Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY and encapsulate client pods #277

Open
2 tasks
nkrkv opened this issue Nov 17, 2016 · 0 comments
Open
2 tasks

DRY and encapsulate client pods #277

nkrkv opened this issue Nov 17, 2016 · 0 comments

Comments

@nkrkv
Copy link
Member

nkrkv commented Nov 17, 2016

Now in clients (browser and electron) the following pattern takes place:

  • There are pods. Some are local to a concrete client, other are shared via xod-client
  • There are “entry point pods”. One for each kind of client. It’s main container is App.jsx

The problem in that App.jsx. It has too many responsibilities and going to be messy.

  • It contains code to wire up pods together and it contains code to wire various routines of particular pods not shared with outside world.
  • App.jsx for xod-client-browser and xod-client-electron contain many duplicated code.

To make thing clearer the refactoring is required.

  • Encapsulate as much local wiring in pods as possible inside pods and expose single PodName.jsx as an API for App.jsx which would simply place it in itself without any logic.
  • Extract the common code of App.jsx to somewhere inside xod-client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
DX Debt
To do
Development

No branches or pull requests

1 participant