Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clp-s: Don't add implicit wildcards ('*') at the beginning and the end of a query (fixes #390). #406

Merged
merged 1 commit into from
May 31, 2024
Merged

clp-s: Don't add implicit wildcards ('*') at the beginning and the end of a query (fixes #390). #406

merged 1 commit into from
May 31, 2024

Conversation

wraymo
Copy link
Contributor

@wraymo wraymo commented May 14, 2024

References

#390

Description

This PR fixes #390, which makes wildcard match consistent for both log-text and variable values. It simply sets add_wildcards to false for all log-text cases.

Validation performed

  • Used clp-s to compress the first 1,000,000 log messages of mongodb dataset.
  • Without the code change, query msg: "wire " returned four results. Now it returns nothing. And *wire * works fine as before.

gibber9809
gibber9809 approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@gibber9809 gibber9809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. PR title is fine for commit message.

@kirkrodrigues kirkrodrigues changed the title clp-s: Do not add implicit wildcard character "*" at the beginning and the end of a query (fixes #390). clp-s: Don't add implicit wildcards ("*") at the beginning and the end of a query (fixes #390). May 31, 2024
@kirkrodrigues kirkrodrigues changed the title clp-s: Don't add implicit wildcards ("*") at the beginning and the end of a query (fixes #390). clp-s: Don't add implicit wildcards ('*') at the beginning and the end of a query (fixes #390). May 31, 2024
@wraymo wraymo merged commit a32ce65 into y-scope:main May 31, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibber9809 gibber9809 gibber9809 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clp-s: Implicit wildcard behaviour is unintuitive
2 participants
@wraymo @gibber9809