Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clp-s: Support ? to match single character in searches against variable value columns #392

Closed
gibber9809 opened this issue May 10, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@gibber9809
Copy link
Contributor

Request

Currently clp-s supports using wildcards to search against variable value columns, but not ? to match a single character. Since this is supported on the log text search path the resulting behaviour is unintuitive.

Possible implementation

The issue is that for this type of query we only enter into the wildcard search path if the predicate contains '*', ignoring ? characters and escaping rules. We need to add some preprocessing along the variable value column search path to match the behaviour of the log text search path.

@gibber9809 gibber9809 added the enhancement New feature or request label May 10, 2024
@wraymo
Copy link
Contributor

wraymo commented May 13, 2024

Our log-text behaviour is to treat ? as *, do we want the same thing?

@kirkrodrigues
Copy link
Member

For clp-text/clp, that logic is a bit buggy (one issue is #243) but the intent was that we perform a wildcard match with the original query (including ?) just after we decompress a message. For clp-json/clp-s, I would say we should treat ? as matching any single character, as intended. We'll fix clp separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants